On Thu, 22 Jul 2004, Tim Jenness wrote:
> Excellent. One quick comment, cvsweb seems to indicate that some of the
> diff is associated with whitespace (eg in psx_ttyname there are quite a
> few changes that aren't really associated with the mingw patch). Is it the
> case that these are because of changes to line feeds? [in which case we
> should really be fixing line feeds before committing from a windows box -
> can cvs be told to do that?]
Hi Tim,
well, that's not white space, just me momentarily switching into anal
retentive mode and failing to resist the temptation to add some curly
braces to some one-line if/then/else statements (those always look wrong
to me). I also have a automatic mode (me not the editor) that strips all
trailing spaces (and occasionally replaces tabs with spaces). I try to
resist when editing other people's code, but clearly don't always succeed!
Re: CRLF, LF and CR & CVS. The advice about all that is only commit files
that you checked out on the same platform and all should be well. So avoid
NFS and Samba shares between different machines, as these tempt you to do
the wrong thing. Haven't looked into testing this advice, so YMMV.
Peter.
|