> Quick comment: If WORDS_BIGENDIAN is meant to be a boolean shouldn't the
> fpp code be written like this:
>
> #if !WORDS_BIGENDIAN
>
> ...
>
> #endif
>
> rather than
>
> #if WORDS_BIGENDIAN == 0
>
> ...
>
> #endif
>
> Or is it really meant to always be defined and have explicit values of 1
> or 0? [I am asking for clarification here, not implying a mistake - I did
> this in GSD using the first technique]
Not sure, I did it this way since everyone else seemed to be doing it this
way. I sort of agree with you (much neater) but am unsure what exactly is
happening as (obviously!) it's always set to 1 on my Mac.
> PS I fixed dsa_tfopen.fpp - the #if READONLY was in the wrong place
> so the file was never opened.
*mutter*
Sorry, erm. Looking at the code thats a _really_ obvious mistake. Can't
think what I was thinking about at the time. How odd.
Have you committed this change to CVS, I don't have the update if so...!?
Al.
|