============================================================================
Today's topic summary
============================================================================
Group: [log in to unmask]
URL:
https://groups.google.com/forum/?utm_source=digest&utm_medium=email#!forum/ccp-petmr-codebot/topics
- [SyneRBI/SIRF] upgrade finding of Gadgetron toolboxes once we update our Gadgetron requirement (Issue #1144) [1 Update]
http://groups.google.com/group/ccp-petmr-codebot/t/83ddac35af33185
- [SyneRBI/SIRF-SuperBuild] Build gadgetron master (#438) [21 Updates]
http://groups.google.com/group/ccp-petmr-codebot/t/e30a9169d58c43e4
- [SyneRBI/SIRF-SuperBuild] GHA: docker always builds master (Issue #775) [1 Update]
http://groups.google.com/group/ccp-petmr-codebot/t/c88fc7825c234e29
- [SyneRBI/SIRF] Fixed dicom output via ImageProcessor chain. (PR #1143) [1 Update]
http://groups.google.com/group/ccp-petmr-codebot/t/79d63731f7732eee
============================================================================
Topic: [SyneRBI/SIRF] upgrade finding of Gadgetron toolboxes once we update our Gadgetron requirement (Issue #1144)
URL: http://groups.google.com/group/ccp-petmr-codebot/t/83ddac35af33185
============================================================================
---------- 1 of 1 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Nov 11 02:49PM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/5166aa48a4bed
We currently find files explicitly https://github.com/SyneRBI/SIRF/blob/b1a476342b5b7674e798c314d2ae32364e7fdde6/src/xGadgetron/cGadgetron/CMakeLists.txt#L45
Newer Gadgetron exports a CMake config
============================================================================
Topic: [SyneRBI/SIRF-SuperBuild] Build gadgetron master (#438)
URL: http://groups.google.com/group/ccp-petmr-codebot/t/e30a9169d58c43e4
============================================================================
---------- 1 of 21 ----------
From: Edoardo Pasca <[log in to unmask]>
Date: Nov 11 07:49AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/4ff868ef8fff2
@paskino pushed 1 commit.
b818fd43b41be9ec50ffe767d2a721a06c2ba8da update packages
--
View it on GitHub:
---------- 2 of 21 ----------
From: Michael Hansen <[log in to unmask]>
Date: Nov 11 07:51AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/4ffa10fec1569
Just a heads up on this. We have a PR going through Gadgetron right now to remove the CPR dependency: https://github.com/gadgetron/gadgetron/pull/1173. That may help you here.
--
---------- 3 of 21 ----------
From: Edoardo Pasca <[log in to unmask]>
Date: Nov 11 07:54AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/4ffcbe8824345
Thanks @hansenms that would solve some issues, however I just made it work...
Next problem is
```
CMake Error at apps/gadgetron/test/CMakeLists.txt:3 (add_executable):
Target "server_tests"
---------- 4 of 21 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Nov 11 08:15AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/500f4f29c11ec
@KrisThielemans commented on this pull request.
> @@ -108,17 +113,19 @@ set(DEFAULT_NIFTYREG_TAG 99d584e2b8ea0bffe7e65e40c8dc818751782d92 )
set(DEFAULT_NIFTYREG_REQUIRED_VERSION 1.5.68)
---------- 5 of 21 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Nov 11 08:39AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/50238ee439f97
I think that this is a Gadgetron bug. I've created https://github.com/gadgetron/gadgetron/issues/1175. I believe it implies we have to build Gadgetron with `BUILD_TESTING=ON`.
--
---------- 6 of 21 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Nov 11 08:41AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/502533f7feafc
@hansenms could you comment if we really should try to build Gadgetron 4.1? It is from Nov 2019. For instance, I found some `GTest` related changes that were merged since then,
---------- 7 of 21 ----------
From: Michael Hansen <[log in to unmask]>
Date: Nov 11 08:50AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/502d57d7f7007
@KrisThielemans if you are moving to a newer version, I would go with the latest version. It is the one that was built most recently and where dependencies are most well understood. There was a
---------- 8 of 21 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Nov 11 08:53AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/502fd64f81055
@paskino had already created https://github.com/gadgetron/gadgetron/issues/1174, so I've closed my issue. I now have a PR to fix Gadgetron
https://github.com/gadgetron/gadgetron/pull/1176
--
---------- 9 of 21 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Nov 11 08:55AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/50317a4032505
@KrisThielemans commented on this pull request.
> @@ -6,10 +6,10 @@ apt-get update -qq
apt-get install -yq --no-install-recommends \
libhdf5-serial-dev \
libboost-dev
---------- 10 of 21 ----------
From: Edoardo Pasca <[log in to unmask]>
Date: Nov 11 10:53AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/5098d940c51e3
@paskino pushed 1 commit.
5892c2bc17ac03e884cd47a02a02db5978fe3456 add libboost-optional-dev
--
View it on GitHub:
---------- 11 of 21 ----------
From: Edoardo Pasca <[log in to unmask]>
Date: Nov 11 11:00AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/509e9cfc534c4
@paskino pushed 1 commit.
f66b998a57a26493d508609411a1b6354e9030c2 update boost dependency and build gadgetron testing
--
View it on GitHub:
---------- 12 of 21 ----------
From: Edoardo Pasca <[log in to unmask]>
Date: Nov 11 11:45AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/50c67b3dea3eb
@paskino pushed 1 commit.
a948fc3fa5191ab69318e7b0e1f5a3714d12da9f build Gadgetron master
--
View it on GitHub:
---------- 13 of 21 ----------
From: Edoardo Pasca <[log in to unmask]>
Date: Nov 11 12:03PM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/50d60acef5758
@paskino pushed 2 commits.
79ecef6baee5aa8871a55e974932594cd0ecf77a looks like we need date
36c4a021df87db8804e528d71d43296d5a3068e4 set install for date
--
View it on GitHub:
---------- 14 of 21 ----------
From: Edoardo Pasca <[log in to unmask]>
Date: Nov 11 12:06PM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/50d83d9a07757
@paskino pushed 1 commit.
c06065463efc1fcd2f3539d3e777f624a8fb835c fix date url/tag
--
View it on GitHub:
---------- 15 of 21 ----------
From: Edoardo Pasca <[log in to unmask]>
Date: Nov 11 12:57PM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/5105658f16a67
@paskino pushed 1 commit.
7d37213ad19ffe35bf3f3b33f3df3e4cca34568d build SIRF
--
View it on GitHub:
---------- 16 of 21 ----------
From: Edoardo Pasca <[log in to unmask]>
Date: Nov 11 12:59PM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/510692821d919
@paskino pushed 1 commit.
6a4a9cdef58760343d02f2a73ecb7be75372846a build ISMRMRD master
--
View it on GitHub:
---------- 17 of 21 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Nov 11 01:30PM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/5121a42703b65
@paskino, https://github.com/gadgetron/gadgetron/pull/1173 has now been merged< so you can remove the CPR requirement again (!). I'd leave the files there, but just remove it from the Gadgetron
---------- 18 of 21 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Nov 11 02:02PM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/513de17080296
@KrisThielemans pushed 2 commits.
48b57b8c782767e37841cd969a7d3b292f097a62 [GHA] fix yaml
a333c62cf343cb811f36495a7fc7e0b206a8f196 make boost libs and version consistent between files
--
---------- 19 of 21 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Nov 11 02:12PM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/51465ad91c392
@KrisThielemans pushed 1 commit.
7c7a264a2e52c777459d6f288347a265574aaa2a corrected boost package names
--
View it on GitHub:
---------- 20 of 21 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Nov 11 02:33PM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/515902fe9ce90
I've fixed the (normal) GHA CI and boost version stuff. Note that this means that 18.04 jobs now fall over quickly as the system boost is too old. Could change them to build boost out of curiosity
---------- 21 of 21 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Nov 11 02:34PM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/5159ab92d98b4
I've cancelled all docker jobs on GHA as they don't test this PR (see #775)
--
Reply to this email directly or view it on GitHub:
============================================================================
Topic: [SyneRBI/SIRF-SuperBuild] GHA: docker always builds master (Issue #775)
URL: http://groups.google.com/group/ccp-petmr-codebot/t/c88fc7825c234e29
============================================================================
---------- 1 of 1 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Nov 11 02:20PM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/514de400ed58d
https://github.com/SyneRBI/SIRF-SuperBuild/blob/a0ad95c056cd7f666d8e09f296d1234227d50bef/docker/Dockerfile#L127-L128
and
============================================================================
Topic: [SyneRBI/SIRF] Fixed dicom output via ImageProcessor chain. (PR #1143)
URL: http://groups.google.com/group/ccp-petmr-codebot/t/79d63731f7732eee
============================================================================
---------- 1 of 1 ----------
From: Evgueni Ovtchinnikov <[log in to unmask]>
Date: Nov 11 04:41AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/4f53a5fe9a5ce
@evgueni-ovtchinnikov pushed 1 commit.
87ba87d006e2cc8c8a8911a3409288d3e0aadfbd [ci skip] restored several-chains demo following PR 1143 bugfix
--
View it on GitHub:
--
You have received this digest because you're subscribed to updates for this group. You can change your settings on the group membership page:
https://groups.google.com/forum/?utm_source=digest&utm_medium=email#!forum/ccp-petmr-codebot/join
.
To unsubscribe from this group and stop receiving emails from it, send an email to [log in to unmask]
########################################################################
To unsubscribe from the SYNERBI-DEVEL list, click the following link:
https://www.jiscmail.ac.uk/cgi-bin/WA-JISC.exe?SUBED1=SYNERBI-DEVEL&A=1
This message was issued to members of www.jiscmail.ac.uk/SYNERBI-DEVEL, a mailing list hosted by www.jiscmail.ac.uk, terms & conditions are available at https://www.jiscmail.ac.uk/policyandsecurity/
