Seems to be that it could sit in either, so whatever is most convenient.

 

Best to put it in CMake, and only call the test when appropriate.

 

 

Thanks,

 

I now think the easiest is to put them in the CIL. They will not execute if also SIRF is not installed.

 

I already had to put some code that checks if SIRF is installed in our code-base

https://github.com/vais-ral/CCPi-Framework/blob/finite_diff_for_sirf/Wrappers/Python/ccpi/framework/BlockDataContainer.py#L30

 

I presume a similar trick can be used in a test file.

 

Edo

 

 

Hi Edo

 

I don’t think that having these tests in the SuperBuild makes sense. Can’t we put them in SIRF, but only run them if CIL is present? This would be similar to running Python tests only when Python was detected.

 

I guess finding Python packages isn’t part of standard CMake (sadly). I found

 

https://github.com/UCL/GreatCMakeCookOff/wiki/*find_package*-for-python-modules (from UCL!), MIT license so ok

 

http://www.nmr.mgh.harvard.edu/~you2/dramms/dramms-1.4.3-source/build/bundle/src/BASIS/src/cmake/FindPythonModules.cmake

(not sure what license)

 

Or maybe there’s something simpler…

 

Hi all

 

What would be the best way to add tests for the CIL/SIRF integration?

 

I have a number of scripts at hand but they do not belong to either SIRF nor CIL, but somehow to both.

I was thinking to create a number of test files test_CIL_01.py.in in the SuperBuild.

 

Any opinions?

 

Edo

 

--
Edoardo Pasca, PhD
Senior Visualisation Scientist
Scientific Computing Department, STFC Rutherford Appleton Laboratory
Fermi Avenue Chilton Didcot OX11 0QX
0044 (0)1235 44 5660, R89 F16
:wq

 

 

To unsubscribe from the CCP-PETMR-DEVEL list, click the following link:
https://www.jiscmail.ac.uk/cgi-bin/webadmin?SUBED1=CCP-PETMR-DEVEL&A=1

 

To unsubscribe from the CCP-PETMR-DEVEL list, click the following link:
https://www.jiscmail.ac.uk/cgi-bin/webadmin?SUBED1=CCP-PETMR-DEVEL&A=1