[log in to unmask] Google Groups
Today's topic summary
View all topics
[CCPPETMR/SIRF] Quaternion (#375)
Richard Brown <[log in to unmask]>: Apr 29 09:34AM -0700

This enables averaging of affine transformation matrices via quaternions
You can view, comment on, or merge this pull request online at:
 
https://github.com/CCPPETMR/SIRF/pull/375
...more
Ashley Gillman <[log in to unmask]>: Apr 29 01:58PM -0700

Hey Rich, there might be some issue with the quaternion averaging.
 
https://arc.aiaa.org/doi/abs/10.2514/1.28949
 
Looks like you should at least divide by the norm to make sure you have a unit ...more
Back to top
[CCPPETMR/SIRF] Run gmi_x* after relevant file has been updated (#372)
Edoardo Pasca <[log in to unmask]>: Apr 29 08:40AM

You'll have to create a custom target depending on `gmi_xstir` and `cstir.h` which will run the specific command you need.
 
--
You are receiving this because you are subscribed to this thread. ...more
Richard Brown <[log in to unmask]>: Apr 29 02:26AM -0700

```
# Re-run gmi_xreg if cReg.h has changed
ADD_CUSTOM_COMMAND(
OUTPUT ""
COMMAND "gmi_xreg"
DEPENDS "../../cReg/cReg.h"
)
```
 
I tried this, but it's not correct. Any ideas?
...more
Edoardo Pasca <[log in to unmask]>: Apr 29 03:18AM -0700

What do you mean "is not correct"?
I normally set the `OUTPUT` but it may be that the relative path to `cReg.h` is not resolved properly.
 
```cmake
 
ADD_CUSTOM_COMMAND(
OUTPUT ...more
Richard Brown <[log in to unmask]>: Apr 29 03:52AM -0700

Using your example everything compiles, but when I change `cReg.h`, `mReg.c` isn't updated accordingly. (which is what I meant by "not correct").
 
--
You are receiving this because you are ...more
Edoardo Pasca <[log in to unmask]>: Apr 29 04:21AM -0700

Is the command `gmi_xreg` issued at any time if you update `cReg.h`? Or the change of `cReg.h` is not picked by CMake?
 
--
You are receiving this because you are subscribed to this thread. ...more
Richard Brown <[log in to unmask]>: Apr 29 05:48AM -0700

I'm not sure whether the change of `cReg.h` isn't being detected (seems unlikely), or if I'm not using the command properly (more likely). At any rate, `gmi_xreg` isn't being run during the `make` ...more
Edoardo Pasca <[log in to unmask]>: Apr 29 01:46PM

I tried on a simplified example. Adding a target works
 
```cmake
add_custom_target(
run_gmi
COMMAND gmi_xreg
DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/head.h"
)
```
...more
Edoardo Pasca <[log in to unmask]>: Apr 29 02:44PM

There are 2 signatures of the `add_custom_command`.
 
You are trying to use the ...more
Back to top
[CCPPETMR/SIRF] Data handle vector (#373)
Richard Brown <[log in to unmask]>: Apr 29 04:07AM -0700

@rijobro pushed 1 commit.
 
b177b21329e4e6454d2978a923300709fdb148cb use vector<T const *> instead of vector<const T*>
 
 
--
You are receiving this because you are subscribed to this thread. ...more
"codecov[bot]" <[log in to unmask]>: Apr 29 04:21AM -0700

# [Codecov](https://codecov.io/gh/CCPPETMR/SIRF/pull/373?src=pr&el=h1) Report
 
> Merging [#373](https://codecov.io/gh/CCPPETMR/SIRF/pull/373?src=pr&el=desc) into ...more
"codecov[bot]" <[log in to unmask]>: Apr 29 11:21AM

# [Codecov](https://codecov.io/gh/CCPPETMR/SIRF/pull/373?src=pr&el=h1) Report
 
> Merging [#373](https://codecov.io/gh/CCPPETMR/SIRF/pull/373?src=pr&el=desc) into ...more
Richard Brown <[log in to unmask]>: Apr 29 05:31AM -0700

Merged #373 into master.
 
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: ...more
Back to top
[CCPPETMR/SIRF] VoxelisedGeometricalInfo should check its axes are valid (#371)
David Atkinson <[log in to unmask]>: Apr 29 04:52AM -0700

Checks at constructor stages are good. The actual code can be tricky* so it should not be repeated elsewhere (though the checks might be called again after some processing).
It can be necessary to ...more
Back to top
[CCPPETMR/SIRF] Fix PET interactive scripts (#374)
Edoardo Pasca <[log in to unmask]>: Apr 29 04:13AM -0700

closes #370
fix functionality of pet interactive examples
renamed files to clarify the order they should be run
uses iterno instead of iter
uses sliceno instead of slice
You can view, comment on, ...more
Edoardo Pasca <[log in to unmask]>: Apr 29 04:15AM -0700

Still standing issue: running the whole script in spyder doesn't run the whole script.
Running the script cell-by-cell works.
 
--
You are receiving this because you are subscribed to this thread. ...more
"codecov[bot]" <[log in to unmask]>: Apr 29 04:48AM -0700

# [Codecov](https://codecov.io/gh/CCPPETMR/SIRF/pull/374?src=pr&el=h1) Report
 
> Merging [#374](https://codecov.io/gh/CCPPETMR/SIRF/pull/374?src=pr&el=desc) into ...more
Back to top
[CCPPETMR/SIRF] Python/PET/interactive demos fail on VM (#370)
Edoardo Pasca <[log in to unmask]>: Apr 29 10:58AM

There are a few problems here:
 
1. the interactive scripts are meant to be executed in a specific order (in spyder) but the order is not so apparent and I suggest to change the name of the file to ...more
Back to top
You have received this digest because you're subscribed to updates for this group. You can change your settings on the group membership page.
To unsubscribe from this group and stop receiving emails from it send an email to [log in to unmask].


To unsubscribe from the CCP-PETMR-DEVEL list, click the following link:
https://www.jiscmail.ac.uk/cgi-bin/webadmin?SUBED1=CCP-PETMR-DEVEL&A=1