Richard Brown <[log in to unmask]>: Feb 05 04:26PM
You can view, comment on, or merge this pull request online at: https://github.com/CCPPETMR/SIRF/pull/304 -- Commit Summary -- * matlab libload_*.m better errors -- File Changes -- ...more |
Richard Brown <[log in to unmask]>: Feb 05 06:02PM
Merged #304 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
Johannes Mayer <[log in to unmask]>: Feb 05 08:10AM -0800
@rijobro The constructor ``` template<class inputType> NiftiImageData3DDisplacement(const inputType * const data, const VoxelisedGeometricalInfo3D &geom) ...more |
Richard Brown <[log in to unmask]>: Feb 05 08:32AM -0800
Yes, I though about this the other day. When creating an image from geometrical info, we actually call this method: `create_from_geom_info`. We could add an argument (`bool is_tensor=false`). ...more |
Johannes Mayer <[log in to unmask]>: Feb 05 08:33AM -0800
I'm very happy with it! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
Richard Brown <[log in to unmask]>: Feb 05 05:24PM
Ok, pushed to master. I also added `ctests` for `NiftiImageData3DTensor`, `NiftiImageData3DDisplacement` and `NiftiImageData3DDeformation` (as I'd already done for `NiftiImageData` and ...more |
Richard Brown <[log in to unmask]>: Feb 05 10:02AM -0800
Ignore bottom comment, managed to do resampling of tensor images too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
Richard Brown <[log in to unmask]>: Feb 05 06:40AM -0800
loading libraries in matlab currently looks like this: ``` try [notfound, warnings] = loadlibrary('miutilities'); catch error('mutilities library failed to load\n') ...more |
Kris Thielemans <[log in to unmask]>: Feb 05 08:19AM -0800
yes. let's remove `try/catch`. It will error out just like the current code, but at least we'll see why. -- You are receiving this because you are subscribed to this thread. Reply to this email ...more |
Richard Brown <[log in to unmask]>: Feb 05 08:26AM -0800
ok, see PR #304. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
Richard Brown <[log in to unmask]>: Feb 05 06:54AM -0800
Reopened #192. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
Richard Brown <[log in to unmask]>: Feb 05 06:55AM -0800
This has started happening again. Most recent error that should be causing it to be red happened during the `cmake` of SIRF: ``` CMake Error at ...more |
Edoardo Pasca <[log in to unmask]>: Feb 05 03:51PM
on what OS? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
Richard Brown <[log in to unmask]>: Feb 05 04:19PM
both unfortunately... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
Richard Brown <[log in to unmask]>: Feb 05 06:52AM -0800
Due to https://github.com/CCPPETMR/SIRF-SuperBuild/commit/5b8cb8961a8db4376c67528abc98fc6442aad6b2 -- You are receiving this because you are subscribed to this thread. Reply to this email ...more |
Richard Brown <[log in to unmask]>: Feb 05 06:51AM -0800
I think this commit has broken SIRF's Travis (https://travis-ci.org/CCPPETMR/SIRF). The superbuild is also failing but returning green (a probem in itself). I'm not sure what the problem is with ...more |
Kris Thielemans <[log in to unmask]>: Feb 05 02:17AM -0800
@rijobro, try doing ```sh DYLD_PRINT_LIBRARIES=YES ctest -VV ``` [see here](https://apple.stackexchange.com/questions/247227/how-to-find-which-shared-library-is-loaded-by-a-process-on-osx) -- ...more |
Richard Brown <[log in to unmask]>: Feb 05 10:23AM
@rijobro pushed 1 commit. 6b051fb547f9fe4858a98f67ec5369558cf19537 print library dependencies for debugging -- You are receiving this because you are subscribed to this thread. ...more |
Richard Brown <[log in to unmask]>: Feb 05 02:43PM
Gave this a go, but currently blocked by #300. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
Johannes Mayer <[log in to unmask]>: Feb 05 12:33AM -0800
This function is useful to loop over the elements. You can view, comment on, or merge this pull request online at: https://github.com/CCPPETMR/SIRF/pull/301 -- Commit Summary -- ...more |
Richard Brown <[log in to unmask]>: Feb 05 02:09AM -0800
Merged #301 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
Richard Brown <[log in to unmask]>: Feb 05 10:12AM
Merged. Just for interest, I was using `get_raw_nifti_sptr()->nvox` before. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on ...more |
Kris Thielemans <[log in to unmask]>: Feb 05 02:12AM -0800
can I ask how you're using this? If we need it, we should have a virtual function higher up (which could just get it from the geo_info) -- You are receiving this because you are subscribed to ...more |
Richard Brown <[log in to unmask]>: Feb 05 02:20AM -0800
Apologies for merging, do you want me to revert? Although we should be using geom_info, I don't fully trust it quite yet (e.g., varying slice distances for MR images). Should we make this an issue ...more |
Johannes Mayer <[log in to unmask]>: Feb 05 02:22AM -0800
I decided to load the segmentation input of my simulation into a 'NiftiImageData3D' (no modality attached, just geometry and image information). At some points I want to loop over all the pixels in ...more |
Richard Brown <[log in to unmask]>: Feb 05 02:08AM -0800
Can I close this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
You have received this digest because you're subscribed to updates for this group. You can change your settings on the group membership page. To unsubscribe from this group and stop receiving emails from it send an email to [log in to unmask]. |
To unsubscribe from the CCP-PETMR-DEVEL list, click the following link:
https://www.jiscmail.ac.uk/cgi-bin/webadmin?SUBED1=CCP-PETMR-DEVEL&A=1