Print

Print


 ============================================================================
Today's topic summary
 ============================================================================

Group: [log in to unmask]
URL: 
  https://groups.google.com/forum/?utm_source=digest&utm_medium=email#!forum/ccp-petmr-codebot/topics


  - [CCPPETMR/SIRF] Remove ismrmrd dependency in sirf/common (#245) [2 Updates]
    http://groups.google.com/group/ccp-petmr-codebot/t/9b682a8ddd7977ae
  - [CCPPETMR/SIRF] Aquisition reader (#236) [6 Updates]
    http://groups.google.com/group/ccp-petmr-codebot/t/87df14ccfa475d17
  - [CCPPETMR/SIRF] SIRFReg (#211) [1 Update]
    http://groups.google.com/group/ccp-petmr-codebot/t/89971dca487c6fe4
  - [CCPPETMR/SIRF] remove boost dependency as much as possible (#241) [1 Update]
    http://groups.google.com/group/ccp-petmr-codebot/t/5a82e8e74d550602
  - [CCPPETMR/SIRF] Sptr functinality for sirf::AcquisitionsVector  (#243) [1 Update]
    http://groups.google.com/group/ccp-petmr-codebot/t/652d319b4e1c6dd4


 ============================================================================
Topic: [CCPPETMR/SIRF] Remove ismrmrd dependency in sirf/common (#245)
URL: http://groups.google.com/group/ccp-petmr-codebot/t/9b682a8ddd7977ae
 ============================================================================

---------- 1 of 2 ----------
From: Richard Brown <[log in to unmask]>
Date: Nov 30 08:57AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/591eb3f4a755a

You can view, comment on, or merge this pull request online at:

  https://github.com/CCPPETMR/SIRF/pull/245

-- Commit Summary --

  * Remove ismrmrd dependency in sirf/common


---------- 2 of 2 ----------
From: Ben Thomas <[log in to unmask]>
Date: Nov 30 09:03AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/5923c7107f595

bathomas commented on this pull request.

I'd consider dropping `ISMRMRD_` from the enums. (But keeping your comment) Maybe `SIRF_`? Also, can we use an`enum class` here? Or explicitly typed enum


 ============================================================================
Topic: [CCPPETMR/SIRF] Aquisition reader (#236)
URL: http://groups.google.com/group/ccp-petmr-codebot/t/87df14ccfa475d17
 ============================================================================

---------- 1 of 6 ----------
From: johannesmayer <[log in to unmask]>
Date: Nov 30 12:09AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/57515038865a9

Squash merge is good with me, thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:

---------- 2 of 6 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Nov 30 12:24AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/575edf3fcd2a3

I'll hold off a bit given the discussion on the mailing list. Unless you tell me you have actually merged your devel branch with master. this commit history looks relatively clean anyway, so I'd be

---------- 3 of 6 ----------
From: johannesmayer <[log in to unmask]>
Date: Nov 30 12:30AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/5763e428457be

This here was performed "according to protocol" I guess, so by doing
```
git fetch --all
git checkout sirf/master
git checkout -b aquisition_reader
```
and then I implemented the changes, pushed

---------- 4 of 6 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Nov 30 01:01AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/577ef9635efb5

ok. and you haven't merged this back into your devle branch yet? and your devel branch is up to date with master? (just checking!)

-- 
You are receiving this because you are subscribed to this

---------- 5 of 6 ----------
From: johannesmayer <[log in to unmask]>
Date: Nov 30 01:04AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/5781436010396

Well... checking is in order as always with me...
I did merge this back into the development branch, since I needed this.

-- 
You are receiving this because you are subscribed to this thread.

---------- 6 of 6 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Nov 30 08:09AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/58f4acd74bde6

Merged #236 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:


 ============================================================================
Topic: [CCPPETMR/SIRF] SIRFReg (#211)
URL: http://groups.google.com/group/ccp-petmr-codebot/t/89971dca487c6fe4
 ============================================================================

---------- 1 of 1 ----------
From: Richard Brown <[log in to unmask]>
Date: Nov 30 08:05AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/58f0db4b3365e

@rijobro pushed 3 commits.

ea9386e  Remove dependence on SIRFRegMisc
4ff8d40  Template everything. matlab, python only float
58f4f55  Remove dependency on boost libs


-- 
You are receiving


 ============================================================================
Topic: [CCPPETMR/SIRF] remove boost dependency as much as possible (#241)
URL: http://groups.google.com/group/ccp-petmr-codebot/t/5a82e8e74d550602
 ============================================================================

---------- 1 of 1 ----------
From: Richard Brown <[log in to unmask]>
Date: Nov 30 08:04AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/58f080e582d37

Ok. Well I've removed linking to the boost libs. If this becomes a problem as the boost version changes, I'll cross that bridge when I get to it.

-- 
You are receiving this because you are


 ============================================================================
Topic: [CCPPETMR/SIRF] Sptr functinality for sirf::AcquisitionsVector  (#243)
URL: http://groups.google.com/group/ccp-petmr-codebot/t/652d319b4e1c6dd4
 ============================================================================

---------- 1 of 1 ----------
From: johannesmayer <[log in to unmask]>
Date: Nov 30 01:00AM -0800
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/577e362d739c1

I want to pretend to have a 1000 objects.
In my development branch I have a class `sirf::MRDynamic ` which carries two things.
1.) all readout lines of the simulation process in the form of a





--
You have received this digest because you're subscribed to updates for this group. You can change your settings on the group membership page: 
  https://groups.google.com/forum/?utm_source=digest&utm_medium=email#!forum/ccp-petmr-codebot/join
.
To unsubscribe from this group and stop receiving emails from it, send an email to [log in to unmask]


########################################################################

To unsubscribe from the CCP-PETMR-DEVEL list, click the following link:
https://www.jiscmail.ac.uk/cgi-bin/webadmin?SUBED1=CCP-PETMR-DEVEL&A=1