[log in to unmask]

Google Groups

Kris Thielemans <[log in to unmask]>: Dec 22 04:49PM -0800 On SIRF Travis, we consistently get errors on the 2 `DEVEL_BUILD=ON` builds on OSX. Example is [here](https://api.travis-ci.org/v3/job/471067032/log.txt). Compilation is fine, but all MR Python test ...more

Kris Thielemans <[log in to unmask]>: Dec 22 04:45PM -0800 Closed #249.   -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/CCPPETMR/SIRF/issues/249#event-2042303512 ...more

Kris Thielemans <[log in to unmask]>: Dec 22 06:59AM -0800 We have `clone` in Python/MATLAB classes, but a few differently called functions in C++. `DataContainer* DataContainer::new_data_container`, `gadgetron::shared_ptr<MRAcquisitionData> clone()`, and ...more

Kris Thielemans <[log in to unmask]>: Dec 22 04:13PM -0800 I found a few more: `gadgetron::shared_ptr<ISMRMRDImageData> ISMRMRDImageData::new_images_container`, `gadgetron::shared_ptr<ISMRMRDImageData> ISMRMRDImageData::clone(...)`, ...more

Kris Thielemans <[log in to unmask]>: Dec 22 04:02PM -0800 KrisThielemans requested changes on this pull request.   Needs a conflict resolution, and a tiny suggestion.   However, given #278, I think we should call `new_data_container_sptr` simply `clone`, ...more

Kris Thielemans <[log in to unmask]>: Dec 22 07:04AM -0800 This seems to overlap with #254. Doesn't that give you what you need? You might need of course some ugly casting. But that can be resolved implementing a `clone_as_sptr` in terms of ...more

You have received this digest because you're subscribed to updates for this group. You can change your settings on the group membership page. To unsubscribe from this group and stop receiving emails from it send an email to [log in to unmask].