Ok great. I’ve pushed the modified version-config.cmake then.

I’m not surprised about USE_SYSTEM_STIR=On failing, after all, there isn’t one! Same for ismrmrd and gadgetron.

Thanks for checking!

Kris

From: [log in to unmask] [mailto:[log in to unmask]]
Sent: 11 October 2017 10:19
To: Thielemans, Kris <[log in to unmask]>; [log in to unmask]
Subject: RE: Gadgetron git tag in SuperBuild

Oops, have not noticed it was OFF, sorry!

Gadgetron is built now and works fine.

By the way, if I try to set USE_SYSTEM_STIR to ON, I get cmake error

USING the system Boost, using BOOST_LIBRARY_DIR=

CMake Error at SuperBuild/External_STIR.cmake:68 (find_package):

   By not providing "FindSTIR.cmake" in CMAKE_MODULE_PATH this project has

   asked CMake to find a package configuration file provided by "STIR", but

   CMake did not find one.

   Could not find a package configuration file provided by "STIR" with any of

   the following names:

     STIRConfig.cmake

     stir-config.cmake

   Add the installation prefix of "STIR" to CMAKE_PREFIX_PATH or set

   "STIR_DIR" to a directory containing one of the above files.  If "STIR"

   provides a separate development package or SDK, be sure it has been

   installed.

Call Stack (most recent call first):

   CMake/ExternalProjectDependency.cmake:593 (include)

   SuperBuild/External_SIRF.cmake:32 (ExternalProject_Include_Dependencies)

   CMake/ExternalProjectDependency.cmake:593 (include)

   CMake/ExternalProjectDependency.cmake:639

(ExternalProject_Include_Dependencies)

   SuperBuild.cmake:93 (ExternalProject_Include_Dependencies)

   CMakeLists.txt:14 (include)

From: Thielemans, Kris [mailto:[log in to unmask]]
Sent: 11 October 2017 09:58
To: Ovtchinnikov, Evgueni (STFC,RAL,SC); [log in to unmask]
Subject: RE: Gadgetron git tag in SuperBuild

Thanks

Did you switch BUILD_GADGETRON=Off at some point before all this?

From: [log in to unmask] [mailto:[log in to unmask]]
Sent: 11 October 2017 09:53
To: Thielemans, Kris <[log in to unmask]>; [log in to unmask]
Subject: RE: Gadgetron git tag in SuperBuild

Attached.

From: Thielemans, Kris [mailto:[log in to unmask]]
Sent: 11 October 2017 09:48
To: Ovtchinnikov, Evgueni (STFC,RAL,SC); [log in to unmask]
Subject: RE: Gadgetron git tag in SuperBuild

Strange. It work for me on the VM.

Can you give some diagnostics?

From: [log in to unmask] [mailto:[log in to unmask]]
Sent: 11 October 2017 09:44
To: Thielemans, Kris <[log in to unmask]>; [log in to unmask]
Subject: RE: Gadgetron git tag in SuperBuild

Issue 51 suggests

cmake -DGadgetron_TAG=00b96376568278a595e78879026bb3b0d5fbb98d  -DGadgetron_URL=https://github.com/gadgetron/gadgetron .

I actually did the same with ccmake, now just tried the above – Gadgetron did not build.

I deleted Gadgetron and Gadgetron-prefix from buildVM  – no effect.

I deleted Gadgetron libraries – same again, even though Gadgetron now does not start!

From: CCP-PETMR Developers list [mailto:[log in to unmask]] On Behalf Of Thielemans, Kris
Sent: 11 October 2017 02:35
To: [log in to unmask]
Subject: Re: Gadgetron git tag in SuperBuild

Hi Evgueni

This was all incorrect. The source of the problem is now described here

https://github.com/CCPPETMR/SIRF-SuperBuild/issues/51

together with a current work-around for testing. It is a problem for the VM though. Suggestions for this issue very welcome.

I did do a brief check then with the new gadgetron version but need your confirmation before we commit this. Let me know.

Kris

From: Thielemans, Kris
Sent: 10 October 2017 12:02
To: Thielemans, Kris <[log in to unmask]>; [log in to unmask]
Subject: RE: Gadgetron git tag in SuperBuild

Ah. Sorry. Stupid advice…

Don’t remove and update, as that will just get you back where you started… You’ll have to set it, configure again, hope that make updates, if not remove buildVM/Gadgetron*

From: CCP-PETMR Developers list [mailto:[log in to unmask]] On Behalf Of Thielemans, Kris
Sent: 10 October 2017 12:00
To: [log in to unmask]
Subject: Re: Gadgetron git tag in SuperBuild

Annoying! This seems related to https://github.com/CCPPETMR/SIRF-SuperBuild/issues/4.

I guess for now you can just remove the build directory and update again.

Kris

PS: you’ll have to set the gadgetron URL as well of course

From: [log in to unmask] [mailto:[log in to unmask]]
Sent: 10 October 2017 11:47
To: Thielemans, Kris <[log in to unmask]>; [log in to unmask]
Subject: RE: Gadgetron git tag in SuperBuild

I have tried your Gadgetron tag on VM, but make has not re-built Gadgetron.

Will have to wait until Edoardo is back, I am afraid.

From: CCP-PETMR Developers list [mailto:[log in to unmask]] On Behalf Of Thielemans, Kris
Sent: 10 October 2017 11:31
To: [log in to unmask]
Subject: Gadgetron git tag in SuperBuild

Hi Edo and Evgueni

Hue has accepted my PR to fix the Gadgetron CMake file to cope with later nvidia libraries. Can you therefore test if using Gadgetron 00b96376568278a595e78879026bb3b0d5fbb98d is fine for SIRF (can’t see why not) and update version-config.cmake accordingly?

Thanks

Kris

PS: we cannot delete the chroot branch on our fork of gadgetron yet, as the current version-config.cmake points to it. I suggest that at final release, we recommend everyone to update and delete the branch about 1 month later.