 |
 |
|
Edoardo Pasca <[log in to unmask]>: Sep 27 01:21PM
@paskino pushed 1 commit. e167bc7 Added MATLABPATH by default -- You are receiving this because you are subscribed to this thread. View it on GitHub: ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 05:11PM
sourceforge still down. I did merge SIRF ctest so this will actually get tested once it's up again. But there are a few comments for the README outstanding :-; -- You are receiving this because ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 04:48PM
KrisThielemans approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 04:50PM
Merged #58. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/CCPPETMR/SIRF/pull/58#event-1268191362 ...more |
|
evgueni-ovtchinnikov <[log in to unmask]>: Sep 27 10:30AM
Switched to the use of std::shared_ptr in xGadgetron and stir::shared_ptr in xSTIR. Generally, different SIRF engines can now use different shared_ptr (as specified in *_shared_ptr,h). ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 05:58AM -0700
@casperdcl do you have any idea why github claims that this PR contains so many commits? This PR is based on master, which was merged to devel recently, from which this branch was created. ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 01:02PM
@evgueni-ovtchinnikov I had a brief look at this. It seems a bit of a hack to me. I guess it works so I'm ok with merging it, but I'm generally quite warry of solving this stuff with `#define`. ...more |
|
evgueni-ovtchinnikov <[log in to unmask]>: Sep 27 01:23PM
Yes, files object_handle.inl are identical – I should have had just one of them in src/common, but I just do not know how to edit CMakeLists so that it is found. Extra template arg would just be ...more |
|
evgueni-ovtchinnikov <[log in to unmask]>: Sep 27 06:59AM -0700
Could it be because I branched it from devel? From: Kris Thielemans [mailto:[log in to unmask]] Sent: 27 September 2017 13:59 To: CCPPETMR/SIRF Cc: Ovtchinnikov, Evgueni (STFC,RAL,SC); ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 07:13AM -0700
FYI, modifying CMake files: 1. create src/common/include/SIRF/common or something 2. in xSTIR/CMakeLists.txt do something like ``` include_directories(${PROJECT_SOURCE_DIR}/src/common/include) ...more |
|
evgueni-ovtchinnikov <[log in to unmask]>: Sep 27 02:32PM
Merged locally, no conflicts. From: Kris Thielemans [mailto:[log in to unmask]] Sent: 27 September 2017 15:14 To: CCPPETMR/SIRF Cc: Ovtchinnikov, Evgueni (STFC,RAL,SC); Mention ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 07:42AM -0700
ok. please push -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
|
evgueni-ovtchinnikov <[log in to unmask]>: Sep 27 07:43AM -0700
Merged #62. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/CCPPETMR/SIRF/pull/62#event-1267931929 ...more |
|
evgueni-ovtchinnikov <[log in to unmask]>: Sep 27 02:43PM
Done From: Kris Thielemans [mailto:[log in to unmask]] Sent: 27 September 2017 15:42 To: CCPPETMR/SIRF Cc: Ovtchinnikov, Evgueni (STFC,RAL,SC); Mention Subject: Re: [CCPPETMR/SIRF] ...more |
|
evgueni-ovtchinnikov <[log in to unmask]>: Sep 27 07:48AM -0700
Merged manually -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 01:58AM -0700
It'll make people's life easier if SIRF gets added to the Matlab path automatically. I suggest that we set `MATLABPATH`, see ...more |
|
Edoardo Pasca <[log in to unmask]>: Sep 27 01:21PM
Closed with https://github.com/CCPPETMR/SIRF-SuperBuild/commit/e167bc77feb039acdac93f6fef4658265b225900 -- You are receiving this because you are subscribed to this thread. Reply to this email ...more |
|
Edoardo Pasca <[log in to unmask]>: Sep 27 01:21PM
Closed #46. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 06:30AM
Currently using ``` set(SIRF_SRC_PATH ${CMAKE_CURRENT_LIST_DIR}/SIRF) ``` but this is incorrect if we build somewhere else from where we cloned. Presumably ``` set(SIRF_SRC_PATH ...more |
|
Edoardo Pasca <[log in to unmask]>: Sep 27 10:23AM
Yes! I found that out yesterday. I've replaced it with `$SOURCE_DOWNLOAD_CACHE` which is a copy of `$CMAKE_CURRENT_BINARY_DIR` -- You are receiving this because you are subscribed to this thread. ...more |
|
Edoardo Pasca <[log in to unmask]>: Sep 27 04:05AM -0700
Closed #42. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
|
Edoardo Pasca <[log in to unmask]>: Sep 27 11:05AM
Closed with https://github.com/CCPPETMR/SIRF-SuperBuild/commit/4cf709b8f83d82fbb633871350db4471cbbeca6f -- You are receiving this because you are subscribed to this thread. Reply to this email ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 02:10AM -0700
@evgueni-ovtchinnikov could you create a PR for this based on your `sirf_sptr` branch? Easier to review it then. I guess this supersedes Casper's #61, so close that one (without merging) by referring ...more |
|
evgueni-ovtchinnikov <[log in to unmask]>: Sep 27 10:40AM
Done. From: Kris Thielemans [mailto:[log in to unmask]] Sent: 27 September 2017 10:11 To: CCPPETMR/SIRF Cc: Ovtchinnikov, Evgueni (STFC,RAL,SC); Mention Subject: Re: [CCPPETMR/SIRF] SIRF ...more |
|
evgueni-ovtchinnikov <[log in to unmask]>: Sep 27 10:37AM
Superseded by #62. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
|
evgueni-ovtchinnikov <[log in to unmask]>: Sep 27 10:37AM
Closed #61. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/CCPPETMR/SIRF/pull/61#event-1267500483 ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 08:17AM
WARNING: This breaks backwards compatibility. Matlab_ROOT_DIR is the variable used by CMake's FindMatlab.cmake so is what we should use as well. Currently we use this to set both variables for ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 08:19AM
If you want to try SIRF FindMatlab branch, use ``` cmake -DSIRF_TAG=FindMatlab ``` Potentially add `-DMatlab_ROOT_DIR=....` if you need it (and for testing) -- You are receiving this because ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 02:02AM -0700
merging this will need updates to the wiki. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 08:41AM
@KrisThielemans pushed 1 commit. 81a36b1 Write warning message that finding Matlab message might take a while -- You are receiving this because you are subscribed to this thread. ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 07:36AM
With the version tracking, we can use the SuperBuild to use different versions of SIRF, STIR etc. However, some CMake options will be version specific. ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 07:56AM
the `rev-list` is essentially impossible in the SuperBuild anyway as we have don't explicitly clone here, but rely on `ExternProject_Add` -- You are receiving this because you are subscribed to ...more |
|
Kris Thielemans <[log in to unmask]>: Sep 27 07:45AM
there are some commits here that were actually in the release. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ...more |
|
You have received this digest because you're subscribed to updates for this group. You can change your settings on the group membership page. To unsubscribe from this group and stop receiving emails from it send an email to [log in to unmask]. |
