Print

Print


 ============================================================================
Today's topic summary
 ============================================================================

Group: [log in to unmask]
URL: 
  https://groups.google.com/forum/?utm_source=digest&utm_medium=email#!forum/ccp-petmr-codebot/topics


  - [CCPPETMR/SIRF] [CMake] Use CMake's FindMatlab.cmake as opposed to our own (#47) [2 Updates]
    http://groups.google.com/group/ccp-petmr-codebot/t/e11036e7859fb7b2
  - [CCPPETMR/SIRF] for PET demos, run_all executes my_osmaposl (#46) [1 Update]
    http://groups.google.com/group/ccp-petmr-codebot/t/bbcf89cba5e2119c
  - [CCPPETMR/SIRF] examples/Matlab/PET/my_osmaposl.m needs a documentation string etc (#45) [1 Update]
    http://groups.google.com/group/ccp-petmr-codebot/t/75a81b869de7a3ef
  - [CCPPETMR/SIRF] pet_data_path.m et al. need to use a global variable (#44) [1 Update]
    http://groups.google.com/group/ccp-petmr-codebot/t/47cd7a745fcab6cc
  - [CCPPETMR/SIRF-SuperBuild] previous install can cause compilation problems for newer versions (#28) [2 Updates]
    http://groups.google.com/group/ccp-petmr-codebot/t/6c3f620994ad0504


 ============================================================================
Topic: [CCPPETMR/SIRF] [CMake] Use CMake's FindMatlab.cmake as opposed to our own (#47)
URL: http://groups.google.com/group/ccp-petmr-codebot/t/e11036e7859fb7b2
 ============================================================================

---------- 1 of 2 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Jul 16 05:42PM -0700
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/79134c54fd84d

The version supplied since CMake 3.3 seems to work fine, so we set this now as minimum CMake version. This should be fine as the SuperBuild needs 3.7 anyway.

Note that it uses Matlab_ROOT_DIR, not

---------- 2 of 2 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Jul 16 05:44PM -0700
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/79158640dbd81

Needs testing on multiple platforms. don't merge yet! Add a comment where tested.

I've tested on CentOS7 (UCL CS system)

-- 
You are receiving this because you are subscribed to this thread.


 ============================================================================
Topic: [CCPPETMR/SIRF] for PET demos, run_all executes my_osmaposl (#46)
URL: http://groups.google.com/group/ccp-petmr-codebot/t/bbcf89cba5e2119c
 ============================================================================

---------- 1 of 1 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Jul 16 05:20PM -0700
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/7900a4dc6dcf3

As `run_all` just executes all .m files, it also runs `my_osmaposl`, which is actually a function used by one of the demos. This results in a confusing `failed` message.

-- 
You are receiving this


 ============================================================================
Topic: [CCPPETMR/SIRF] examples/Matlab/PET/my_osmaposl.m needs a documentation string etc (#45)
URL: http://groups.google.com/group/ccp-petmr-codebot/t/75a81b869de7a3ef
 ============================================================================

---------- 1 of 1 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Jul 17 12:19AM
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/78ff56cd914f1

it needs a small preamble (and license info)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:


 ============================================================================
Topic: [CCPPETMR/SIRF] pet_data_path.m et al. need to use a global variable (#44)
URL: http://groups.google.com/group/ccp-petmr-codebot/t/47cd7a745fcab6cc
 ============================================================================

---------- 1 of 1 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Jul 17 12:16AM
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/78fd1ad285a66

`pet_data_path` checks for `SIRF_PET_DATA_PATH` but this will never work. If we want this, we would need
to add
```
global SIRF_PET_DATA_PATH
```
Its documentation will need to mention this


 ============================================================================
Topic: [CCPPETMR/SIRF-SuperBuild] previous install can cause compilation problems for newer versions (#28)
URL: http://groups.google.com/group/ccp-petmr-codebot/t/6c3f620994ad0504
 ============================================================================

---------- 1 of 2 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Jul 16 03:56PM -0700
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/78b760c4b930e

external packages are installed (by default in `INSTALL`, and therefore include files in `INSTALL/include`). This works fine at first build. However, when the include files of one of the external

---------- 2 of 2 ----------
From: Kris Thielemans <[log in to unmask]>
Date: Jul 16 11:01PM
URL: http://groups.google.com/group/ccp-petmr-codebot/msg/78bbb7ba3045e

STIR bug filed in https://github.com/UCL/STIR/issues/85


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:





--
You have received this digest because you're subscribed to updates for this group. You can change your settings on the group membership page: 
  https://groups.google.com/forum/?utm_source=digest&utm_medium=email#!forum/ccp-petmr-codebot/join
.
To unsubscribe from this group and stop receiving emails from it, send an email to [log in to unmask]