Print

Print


I've pushed the PAL fix.

On Wed, Feb 4, 2015 at 11:08 AM, Peter W. Draper <[log in to unmask]>
wrote:

> On Wed, 4 Feb 2015, Tim Jenness wrote:
>
>  On Wed, Feb 4, 2015 at 9:59 AM, Tim Lister <[log in to unmask]> wrote:
>>       Hi all, I have recently found myself building from git checkout on
>> completely clean
>>       machines without any prior installs which could form traps for the
>> unwary. I have
>>       found 2 problems in the instructions/dependencies which affect
>> clean installs:
>>
>>       1) The README was recently changed to say (e.g for tcsh):
>>          e.g.:
>>             % setenv TEXINPUTS $STARLINK_DIR/share/latexsupport//:
>>
>>       In a clean install, $STARLINK_DIR will not be defined, there are no
>> instructions in
>>       the README to set $STARLINK_DIR nor is there any tree of installed
>> files to point it
>>       to.
>>
>>       I worked round this by doing (from in the root of the git checkout):
>>        setenv TEXINPUTS `pwd`/applications/latexsupport//:
>>
>>
>> It's meant to say $STARLINK (since that's a build time environment
>> variable). Saying that, I thought that it was no longer needed at all as
>> the documentation build system now automatically sets it.
>>
>
> That should really be STARCONF_DEFAULT_PREFIX not STARLINK. STARLINK is
> used internally by the build system and is set by the STAR_DEFAULTS macro,
> but should not be set externally.
>
>        2) The bootstrapping fails during the './configure -C' step in
>> libext/pal with the
>>       following message:
>>       checking for eraCal2jd in -lerfa... no
>>       checking for iauCal2jd in -lsofa_c... no
>>       configure: error: Neither ERFA nor SOFA library located. Can not
>> continue
>>       configure: error: ./configure failed for pal
>>       configure: error: ./configure failed for libext
>>
>>       I think this indicates that either erfa or sofa should be built by
>> the 'make
>>       configure-deps' step. I have got round this by manually going into
>> thirdparty/sofa and
>>       doing a './bootstrap && ./configure && make && make install' series
>> and then reran the
>>       top-level configure.
>>
>>
>> This is because configure is assuming $STARLINK_DIR is set and if it's
>> not set it assumes PAL is
>> being configured outside of the build environment. I probably need to
>> change that to use
>> $STARCONF_DEFAULT_STARLINK. It used to look for $STARLINK but that broke
>> builds outside of
>> Starlink because the build system was always forcing it to be /star
>> before the test could be done.
>>
>
> Maybe that should also be STARCONF_DEFAULT_PREFIX, since you want the sofa
> etc. that have just been built and installed, not one potentially from
> another tree?
>
>
>        (The third, known issue is with the standard version of the Perl Tk
>> module; any plans
>>       to uprev to the development version which seems to resolve the
>> issue for several
>>       people?)
>>
>>
>> That should be trivial to do by explicitly specifying the version in
>> cpan.deps -- just need to
>> remember to remove the tweak when the real version is released (and I
>> wonder if the test skipping
>> code will still work).
>>
>>
>>       I think it would be good to resolve these issues so that the "out
>> of the box"
>>       experience is smoother for new players.
>>
>>
>> Absolutely.
>>
>> --
>> Tim Jenness
>>
>>
>>
>>
> --
> Peter W. Draper, http://astro.dur.ac.uk/~pdraper
>