Branch: refs/heads/master
Home: https://github.com/Starlink/starlink
Commit: 4d81655c098c7b2766507781194df81e5f4f1565
https://github.com/Starlink/starlink/commit/4d81655c098c7b2766507781194df81e5f4f1565
Author: David Berry <[log in to unmask]>
Date: 2013-12-10 (Tue, 10 Dec 2013)
Changed paths:
M applications/smurf/libsmf/smf_iteratemap.c
Log Message:
-----------
smurf: Fix memory leak when using initial sky option in makemap
This bug could also cause a seg fault to occur if an error has occurred
previously.
Commit: 76b8ac3badc89f958fd1751e0fed820218a7e5c1
https://github.com/Starlink/starlink/commit/76b8ac3badc89f958fd1751e0fed820218a7e5c1
Author: David Berry <[log in to unmask]>
Date: 2013-12-10 (Tue, 10 Dec 2013)
Changed paths:
M applications/smurf/scripts/skyloop.py
Log Message:
-----------
smurf: Fix skyloop bug that caused uncleaned data to be included in map
This bug caused the second and subsequent invocations of makemap to
use uncleaned data to make the map.
Commit: 466ca7fd16fcc0c55b990c1b2fd29b8d065fbae1
https://github.com/Starlink/starlink/commit/466ca7fd16fcc0c55b990c1b2fd29b8d065fbae1
Author: David Berry <[log in to unmask]>
Date: 2013-12-10 (Tue, 10 Dec 2013)
Changed paths:
M applications/smurf/scripts/skyloop.py
Log Message:
-----------
smurf: Fix issue with skyloop and ast.skip
Previously, the second and subsequent invocations of makemap were doing a
number of real iterations if ast.skip was supplied greater than zero.
Each invocation of makemap (except maye the first) now, correctly, does only
one iteration.
Commit: 8f20711c90e7d924aa5ee23ac5b981baac19e4c1
https://github.com/Starlink/starlink/commit/8f20711c90e7d924aa5ee23ac5b981baac19e4c1
Author: David Berry <[log in to unmask]>
Date: 2013-12-10 (Tue, 10 Dec 2013)
Changed paths:
M applications/smurf/libsmf/smf.h.source
M applications/smurf/libsmf/smf_addmap1.c
M applications/smurf/libsmf/smf_iteratemap.c
Log Message:
-----------
smurf: Fix bug that cuased first contchunk to get double weight
Before e93e76879, smf_iteratemap used the returned map array to hold the
first chunk, and allocated memory for any remaining chunks. smf_addmap1
used this fact to identify when the first chunk was being processed [OK -
I know - a very bad idea]. Since e93e76879, the first chunk is now stored
in allocated memory just like all other chunks. This caused smf_addmap1
to treat the first chunk like all the other chunks, ignoring the fact
that the first chunk is already present in the supplied arrays. The
upshot of this was that the first chunk got included twice in the
returned map, effectively giving it double weight.
smf_addmap1 now has an extra parameter to indicate if the first conchunk
is being processed.
Compare: https://github.com/Starlink/starlink/compare/a395d096e14c...8f20711c90e7
