On Fri, Aug 3, 2012 at 8:27 AM, Peter W. Draper <[log in to unmask]> wrote:
On Wed, 1 Aug 2012, Tim Jenness wrote:

On Wed, Aug 1, 2012 at 8:18 AM, Tim Jenness <[log in to unmask]> wrote:


      On Wed, Aug 1, 2012 at 1:12 AM, Peter W. Draper
      <[log in to unmask]> wrote:

AC_PATH_XTRA doesn't do that for X_LIBS either, we add this to
the _LDADD flags in the Makefile.am. So correspondindly we
should add X_CFLAGS to the (I'd guess) AM_CFLAGS in Makefile.am.

Ah yes. http://code.ohloh.net reinforces that approach so I'll fix
everything up.

Peter, can you have a look at skycat? I'm not sure which bit of a
Makefile.in file I'm meant to add $X_CFLAGS. It currently fails on Mountain
Lion with clang/clang++ version 4 because the X11 include files are missing.

Don't think that's relevant for skycat. What we really need is a patch to the AC_PATH_X macro that searches /opt/X11, Tk etc. use this to locate X.


That's a secondary issue. Since I updated from Lion I still have /usr/X11 on my system despite /opt/X11 being the only location for fresh installs. My recent path to add $X_CFLAGS to the builds fixed everything except skycat (and I assume GAIA). Skycat still can't find /usr/X11/include. Since skycat doesn't use a configure.ac, I'm not sure where to put the fix in the configure.in files to use $X_CFLAGS.

It's not clear to me that adding /opt/X11 will fix skycat without the X_CFLAGS patch.

 

PS Skycat on OSX now modifies skycat/linux/skycat.spec replacing all the .so entries with .dylib. This annoys git due to the modifications of a committed file. Should the file be in the repository and why is a linux file modified on darwin? 

The latter part is clearly just too much effort not too. I've removed this file from the repository. Hah yes, I see you are top! And I only write Tcl? And Malcolm Fortran 77.


That's because of the great CVS migration of 2005.

-- 
Tim Jenness