Hi all
Sorry, by looking at the code (if I have the correct link) I just realised that it is not really ready for the final review.
Seems like there are a few outstanding items, in the way radiative corrections are included in the generator (repeated sequences of
processing steps / too much “logic” is encoded in the configuration XML file, whereas that should happen in code). Also, seems like
the necessary event record extensions in order to keep track of the incoming probe and outgoing leptons both before and after radiation
were done only for the probe. This code seems to be at the stage that we left it after discussions with Adi at Trento. What is the goal
of the review? Do we need to focus on how to go about implementing the outstanding items?
cheers
C
On 16 Jul 2019, at 23:47, Gallagher, Hugh R <[log in to unmask]<mailto:[log in to unmask]>> wrote:
Hi Everyone -
It sounds like this Friday at 8 CT is our best shot for a time in the near future. Let’s try to meet then to start the discussion. As Marco suggested, it would be helpful if people code look at the code and send comments/questions.
Adi, can you let us know if there are any documents available that we should review in preparation for the meeting, besides the code?
We’ll use zoom: https://fnal.zoom.us/j/6106329396
Cheers, Hugh
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Hugh Gallagher
Professor and Department Chair
<SAS_PhysAstro_horiz-lockup-BK+BL.png>
On Jul 12, 2019, at 7:40 AM, Marco Roda <[log in to unmask]<mailto:[log in to unmask]>> wrote:
Hi all,
Costas and I are travelling that day.
In principle we will be able to make it to the review, but right now we cannot really promise much more than that.
Sorry for the inconvenience.
Cheers,
Marco
Il 2019-07-10 18:05 Gallagher, Hugh R ha scritto:
July 19 at 8 CT would work for me. Cheers, Hugh
_~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~_
_Hugh Gallagher_
_Professor and Department Chair_
On Jul 10, 2019, at 11:42 AM, adi ashkenazi <[log in to unmask]<mailto:[log in to unmask]>>
wrote:
Dear All,
I’d be happy to meet next Friday, but available only at 8 am CT.
Could this work for you?
Looking forward,
adi
On 10 Jul 2019, at 9:00, Dytman, Steven A <[log in to unmask]<mailto:[log in to unmask]>> wrote:
Hugh,
I'm happy to have you organize the reviews.
Next 2 weeks are restricted for me. Many of the principals are here
for a
workshop. I will be away Tues-Thur morn next week. I am free
following
week when you are away, then away week after that.
Ugh, complicated. Next Fri (July 19) might work. What do you
think, Adi?
regards,
Steve
On 7/8/2019 10:54 AM, Gallagher, Hugh R wrote:
Hi Everyone -
I think physics-wise this does fit in the PPWG, and I’m happy to
organize the reviews. Steve, you've had more contact with the
developer so if you’d like to organize the reviews I’m
completely happy with that too, I’ll let you decide.
The next two weeks are good for me, I’m currently scheduled for
vacation 7/22-7/29.
Cheers, Hugh
On Jul 5, 2019, at 2:35 PM, Dytman, Steven A <[log in to unmask]<mailto:[log in to unmask]>>
wrote:
Costas,
thanks for your thoughts.
On 7/5/2019 2:25 PM, Constantinos Andreopoulos wrote:
Thanks for consulting from the beginning Steve, but this is an
opportunity for others to have a say too. From the discussions at
Trento I can recall a number of simplifications / approximations
that need to be discussed and agreed more broadly before deployment.
Also, the changes in structure are significant and, as always, this
is not purely a code issue but a physics issue too: every
factorisation constraints the kinds of future developments that
would fit in and be able to reuse existing code, so we need to get
this right. I don't disagree with anything above, never tried to say
anything otherwise.
Also, we need a set of validations within GENIE, and not external
to GENIE, otherwise we won’t be in position to tell if bugs creep
in. Adi's checks were using GENIE and external data. Yes, it was
before you guys made many changes
so validation will be redone. I was only expressing some optimism
that significant checks are
already done.
regards,
Steve
cheers
C
--
PROFESSOR COSTAS ANDREOPOULOS, _FHEA_
_Chair of Experimental Particle Physics_
University of Liverpool & STFC / RAL
http://costas.andreopoulos.eu<http://costas.andreopoulos.eu/> [1]
Sent from my iPhone
On 5 Jul 2019, at 18:40, Dytman, Steven A <[log in to unmask]<mailto:[log in to unmask]>> wrote:
Marco, Adi,
thanks for providing code for this advance. I consulted with Adi on
physics
from the beginning and Marco has taken lead on code structure
issues. I've
already seen plots compared to e4nu data where I am a collaborator;
they
look
reasonable.
I don't care who calls the meeting. For me, next 2 weeks are a bit
busy,
would hope for the following week. Perhaps, that's trouble for
others?
regards,
Steve
On 7/5/2019 12:17 PM, Marco Roda wrote:
Dear all,
I just had a chat with Adi about the status of the radiation
corrections for electron scattering.
According to her, the bulk of the work is done, especially from
the
point of the framework. She is also ready to start testing.
I suggest that before extensive testing we should have a code
review as
the number of changes quite large and touch a number of different
places.
To facilitate this operation I created a "fake" pull request that
should not be accepted but it's there in order to identify the
changes.
The pull request is here
https://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGENIE-MC%2FGenerator%2Fpull%2F40&data=02%7C01%7Cdytman%40PITT.EDU%7C2987b8938c90473fd75f08d70164537e%7C9ef9f489e0a04eeb87cc3a526112fd0d%7C1%7C1%7C636979402726199119&sdata=w7BwiQp2dQlnSeA4gxysMP3NfYT4oS%2BEh1l093%2FCgIg%3D&reserved=0
[2]
I invite everybody to start having a look look and send opinions
before
an actual code review, which I believe we should schedule ASAP.
Adi already has a list of tests she will perform that should be
discussed in the relevant WG.
This was was kind supervised by Steve Dytman. Is that him who
should
run the review? Or it's Hugh, since we are talking about a primary
interaction process?
Please, let us know so that we can move ahead.
Cheers,
Marco
########################################################################
To unsubscribe from the NEUTRINO-MC-CORE list, click the following
link:
https://www.jiscmail.ac.uk/cgi-bin/webadmin?SUBED1=NEUTRINO-MC-CORE&A=1
[3]
-------------------------
To unsubscribe from the NEUTRINO-MC-CORE list, click the following
link:
https://www.jiscmail.ac.uk/cgi-bin/webadmin?SUBED1=NEUTRINO-MC-CORE&A=1
[3]
-------------------------
To unsubscribe from the NEUTRINO-MC-CORE list, click the following
link:
https://www.jiscmail.ac.uk/cgi-bin/webadmin?SUBED1=NEUTRINO-MC-CORE&A=1
[4]
-------------------------
To unsubscribe from the NEUTRINO-MC-CORE list, click the following
link:
https://www.jiscmail.ac.uk/cgi-bin/webadmin?SUBED1=NEUTRINO-MC-CORE&A=1
-------------------------
To unsubscribe from the NEUTRINO-MC-CORE list, click the following
link:
https://www.jiscmail.ac.uk/cgi-bin/webadmin?SUBED1=NEUTRINO-MC-CORE&A=1
-------------------------
To unsubscribe from the NEUTRINO-MC-CORE list, click the following
link:
https://www.jiscmail.ac.uk/cgi-bin/webadmin?SUBED1=NEUTRINO-MC-CORE&A=1
Links:
------
[1]
https://nam05.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcostas.andreopoulos.eu%2F&data=02%7C01%7Cdytman%40PITT.EDU%7Ca6eefc45250f4568c65208d703b42100%7C9ef9f489e0a04eeb87cc3a526112fd0d%7C1%7C0%7C636981944501882619&sdata=0EArLyIDv3RGPM7M9vI3Ahm3eb40R%2BjguxaFF00AEm0%3D&reserved=0
[2]
https://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGENIE-MC%2FGenerator%2Fpull%2F40&data=02%7C01%7Cdytman%40PITT.EDU%7Ca6eefc45250f4568c65208d703b42100%7C9ef9f489e0a04eeb87cc3a526112fd0d%7C1%7C0%7C636981944501882619&sdata=opsnGKsztW8Z%2FktrGY6E9OVD7iB%2F2a7xuAFQtdKyVAo%3D&reserved=0
[3]
https://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.jiscmail.ac.uk%2Fcgi-bin%2Fwebadmin%3FSUBED1%3DNEUTRINO-MC-CORE%26A%3D1&data=02%7C01%7Cdytman%40PITT.EDU%7Ca6eefc45250f4568c65208d703b42100%7C9ef9f489e0a04eeb87cc3a526112fd0d%7C1%7C0%7C636981944501892614&sdata=kOYS6jbq6xVDF6UNgb0REaO6wTf4jd1L9QUui0sY9WQ%3D&reserved=0
[4]
https://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.jiscmail.ac.uk%2Fcgi-bin%2Fwebadmin%3FSUBED1%3DNEUTRINO-MC-CORE%26A%3D1&data=02%7C01%7Cdytman%40PITT.EDU%7Ca6eefc45250f4568c65208d703b42100%7C9ef9f489e0a04eeb87cc3a526112fd0d%7C1%7C0%7C636981944501902613&sdata=V2RNvmwAimhgIZZ2%2Bb20Kg7WlEmIj1Zf7dxTmamoKTs%3D&reserved=0
--
Marco Roda
PhD in Physics
________________________________
To unsubscribe from the NEUTRINO-MC-CORE list, click the following link:
https://www.jiscmail.ac.uk/cgi-bin/webadmin?SUBED1=NEUTRINO-MC-CORE&A=1
########################################################################
To unsubscribe from the NEUTRINO-MC-CORE list, click the following link:
https://www.jiscmail.ac.uk/cgi-bin/webadmin?SUBED1=NEUTRINO-MC-CORE&A=1
|
