On Sat, 22 Jul 2017, Graham Bell wrote:
> The Starlink release build process (as on the wiki page "StarlinkRelease")
> needs the update for astSlaAdd, astSpecAdd and astTimeAdd as otherwise an
> error occurs at the build-native step due to the new nargs parameter not being
> supplied. If you want to be able to run "ant ... test" with either version of
> AST, we could just take away the two new "assertTrue(raised);" lines from the
> test -- they check something that wasn't being tested before.
Well yes, but this change
(jniast/src/testcases/uk/ac/starlink/ast/AstTest.java at 345e9d6)
also removes a test that was there before, namely that the two
timeAdd calls you have now wrapped in try/catch blocks executed
without error. I don't really recall what's being tested here,
but effectively commenting out tests that fail following an
update looks questionable.
--
Mark Taylor Astronomical Programmer Physics, Bristol University, UK
[log in to unmask] +44-117-9288776 http://www.star.bris.ac.uk/~mbt/
|