On 22 July 2017 at 05:21, Graham Bell <[log in to unmask]> wrote:
>> [...] the src/lib/*/jniast_libs.jar native files need to be recompiled and
>> committed for all supported architectures.
>
>
> Hello,
>
> I've done that for Linux and hopefully fixed the errors which were
> preventing us compiling them on Mac OS X.
>
> The Starlink release build process (as on the wiki page "StarlinkRelease")
> needs the update for astSlaAdd, astSpecAdd and astTimeAdd as otherwise an
> error occurs at the build-native step due to the new nargs parameter not
> being supplied. If you want to be able to run "ant ... test" with either
> version of AST, we could just take away the two new "assertTrue(raised);"
> lines from the test -- they check something that wasn't being tested before.
>
> Best regards,
> Graham
I'm not sure I understand. What is it that requires the new nargs
parameters, and why are they required? What is the problem with just
leaving jniast as it is? Just picking up one change from the current
version of AST and ignoring all the countless other changes that have
happened since the last rebuild of the native jniast libraries seems a
bit odd.
David
|