JiscMail Logo
Email discussion lists for the UK Education and Research communities

Help for STARDEV Archives


STARDEV Archives

STARDEV Archives


STARDEV@JISCMAIL.AC.UK


View:

Message:

[

First

|

Previous

|

Next

|

Last

]

By Topic:

[

First

|

Previous

|

Next

|

Last

]

By Author:

[

First

|

Previous

|

Next

|

Last

]

Font:

Proportional Font

LISTSERV Archives

LISTSERV Archives

STARDEV Home

STARDEV Home

STARDEV  January 2015

STARDEV January 2015

Options

Subscribe or Unsubscribe

Subscribe or Unsubscribe

Log In

Log In

Get Password

Get Password

Subject:

[Starlink/starjava] 5bd7b3: ttools: fix serious multi-SSA protocol bug

From:

GitHub <[log in to unmask]>

Reply-To:

Starlink development <[log in to unmask]>

Date:

Wed, 21 Jan 2015 07:25:53 -0800

Content-Type:

multipart/mixed

Parts/Attachments:

Parts/Attachments

text/plain (92 lines)

  Branch: refs/heads/master
  Home:   https://github.com/Starlink/starjava
  Commit: 5bd7b327162e2b0c2d27233fb978f3b95d61a018
      https://github.com/Starlink/starjava/commit/5bd7b327162e2b0c2d27233fb978f3b95d61a018
  Author: Mark Taylor <[log in to unmask]>
  Date:   2015-01-20 (Tue, 20 Jan 2015)

  Changed paths:
    M topcat/src/docs/sun253.xml
    M ttools/src/docs/sun256.xml
    M ttools/src/main/uk/ac/starlink/ttools/cone/SsaConeSearcher.java

  Log Message:
  -----------
  ttools: fix serious multi-SSA protocol bug

SsaConeSearcher was failing to add the mandatory "REQUEST=queryData"
parameter to HTTP requests when making SSA queries.
So correct SSA services (e.g. DaCHS) would reject the request,
though some lenient ones might allow it.
I think this bug has been present in the topcat and stilts multi-SSA
clients (though not the topcat single SSA query window) for ever :-(.
Reported by Petr Skoda.


  Commit: a2d5656ba11a64e842e68f1f6d881ff272c1b7cd
      https://github.com/Starlink/starjava/commit/a2d5656ba11a64e842e68f1f6d881ff272c1b7cd
  Author: Mark Taylor <[log in to unmask]>
  Date:   2015-01-21 (Wed, 21 Jan 2015)

  Changed paths:
    M fits/src/main/uk/ac/starlink/fits/ColFitsStarTable.java
    M fits/src/main/uk/ac/starlink/fits/ColFitsTableBuilder.java
    M topcat/src/docs/sun253.xml
    M ttools/src/docs/sun256.xml
    M votable/src/main/uk/ac/starlink/votable/ColFitsPlusTableBuilder.java

  Log Message:
  -----------
  fits: add nasty hack around LDAC FITS format idiosyncracies

This is about the LDAC FITS variant:
http://marvinweb.astro.uni-bonn.de/data_products/THELIWWW/LDAC/LDAC_concepts.html

The first (LDAC_IMHEAD) table extension contains a single-cell table
where the cell's content is an array of FITS headers.
In auto-format-detection mode this confuses STIL into thinking
that the file is in colfits format, which in turn means that
the StarTableFactory.makeStarTables method ignores the second
(LDAC_OBJECTS) table extension, since colfits is not
multi-table-capable.

Add a hack to spot LDAC_IMHEAD HDUs in colfits and reject them as
colfits.


  Commit: 234d2fd22381a757b7e5b8486317dcf94b6daf22
      https://github.com/Starlink/starjava/commit/234d2fd22381a757b7e5b8486317dcf94b6daf22
  Author: Mark Taylor <[log in to unmask]>
  Date:   2015-01-21 (Wed, 21 Jan 2015)

  Changed paths:
    M topcat/src/docs/sun253.xml
    M ttools/src/docs/sun256.xml
    M votable/src/main/uk/ac/starlink/votable/Decoder.java

  Log Message:
  -----------
  votable: improve Decoder behaviour for unknown datatypes

When a VOTable FIELD is encountered with an unknown (i.e. illegal)
value of the datatype attribute, an UnknownDecoder is used
(though the VOTable parser would be well within its rights to
abort the parse in that case).

Previously, this UnknownDecoder has a content class of String[].
This caused problems when serializing to FITS, since FITS can't
serialize arrays of uknown length - in general serializing arrays
is problematic.  The FITS serializer ended up throwing a
NullPointerException when attempting to serialize values from that
column, which was itself an error I haven't fixed.

Now, UnknownDecoder has a content class of (scalar) String.
This is much more sensible and easier to implement, and it
avoids (any?) problems with serialization.
I don't know why I didn't do it like that in the first place,
but from the history, it looks like it might be an editing
error in 2003(!).  Surprised it hasn't shown up since then.


Compare: https://github.com/Starlink/starjava/compare/674e50df0a0f...234d2fd22381

Top of Message | Previous Page | Permalink

JiscMail Tools


RSS Feeds and Sharing


Advanced Options


Archives

December 2023
January 2023
December 2022
July 2022
June 2022
April 2022
March 2022
December 2021
October 2021
July 2021
April 2021
January 2021
October 2020
September 2020
August 2020
May 2020
November 2019
October 2019
July 2019
June 2019
February 2019
January 2019
December 2018
November 2018
August 2018
July 2018
May 2018
April 2018
March 2018
February 2018
December 2017
October 2017
August 2017
July 2017
May 2017
April 2017
February 2017
January 2017
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
May 2016
April 2016
March 2016
February 2016
January 2016
December 2015
October 2015
September 2015
August 2015
April 2015
March 2015
February 2015
January 2015
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
2004
April 2003
2003


JiscMail is a Jisc service.

View our service policies at https://www.jiscmail.ac.uk/policyandsecurity/ and Jisc's privacy policy at https://www.jisc.ac.uk/website/privacy-notice

For help and support help@jisc.ac.uk

Secured by F-Secure Anti-Virus CataList Email List Search Powered by the LISTSERV Email List Manager