Branch: refs/heads/master
Home: https://github.com/Starlink/starjava
Commit: 5bd7b327162e2b0c2d27233fb978f3b95d61a018
https://github.com/Starlink/starjava/commit/5bd7b327162e2b0c2d27233fb978f3b95d61a018
Author: Mark Taylor <[log in to unmask]>
Date: 2015-01-20 (Tue, 20 Jan 2015)
Changed paths:
M topcat/src/docs/sun253.xml
M ttools/src/docs/sun256.xml
M ttools/src/main/uk/ac/starlink/ttools/cone/SsaConeSearcher.java
Log Message:
-----------
ttools: fix serious multi-SSA protocol bug
SsaConeSearcher was failing to add the mandatory "REQUEST=queryData"
parameter to HTTP requests when making SSA queries.
So correct SSA services (e.g. DaCHS) would reject the request,
though some lenient ones might allow it.
I think this bug has been present in the topcat and stilts multi-SSA
clients (though not the topcat single SSA query window) for ever :-(.
Reported by Petr Skoda.
Commit: a2d5656ba11a64e842e68f1f6d881ff272c1b7cd
https://github.com/Starlink/starjava/commit/a2d5656ba11a64e842e68f1f6d881ff272c1b7cd
Author: Mark Taylor <[log in to unmask]>
Date: 2015-01-21 (Wed, 21 Jan 2015)
Changed paths:
M fits/src/main/uk/ac/starlink/fits/ColFitsStarTable.java
M fits/src/main/uk/ac/starlink/fits/ColFitsTableBuilder.java
M topcat/src/docs/sun253.xml
M ttools/src/docs/sun256.xml
M votable/src/main/uk/ac/starlink/votable/ColFitsPlusTableBuilder.java
Log Message:
-----------
fits: add nasty hack around LDAC FITS format idiosyncracies
This is about the LDAC FITS variant:
http://marvinweb.astro.uni-bonn.de/data_products/THELIWWW/LDAC/LDAC_concepts.html
The first (LDAC_IMHEAD) table extension contains a single-cell table
where the cell's content is an array of FITS headers.
In auto-format-detection mode this confuses STIL into thinking
that the file is in colfits format, which in turn means that
the StarTableFactory.makeStarTables method ignores the second
(LDAC_OBJECTS) table extension, since colfits is not
multi-table-capable.
Add a hack to spot LDAC_IMHEAD HDUs in colfits and reject them as
colfits.
Commit: 234d2fd22381a757b7e5b8486317dcf94b6daf22
https://github.com/Starlink/starjava/commit/234d2fd22381a757b7e5b8486317dcf94b6daf22
Author: Mark Taylor <[log in to unmask]>
Date: 2015-01-21 (Wed, 21 Jan 2015)
Changed paths:
M topcat/src/docs/sun253.xml
M ttools/src/docs/sun256.xml
M votable/src/main/uk/ac/starlink/votable/Decoder.java
Log Message:
-----------
votable: improve Decoder behaviour for unknown datatypes
When a VOTable FIELD is encountered with an unknown (i.e. illegal)
value of the datatype attribute, an UnknownDecoder is used
(though the VOTable parser would be well within its rights to
abort the parse in that case).
Previously, this UnknownDecoder has a content class of String[].
This caused problems when serializing to FITS, since FITS can't
serialize arrays of uknown length - in general serializing arrays
is problematic. The FITS serializer ended up throwing a
NullPointerException when attempting to serialize values from that
column, which was itself an error I haven't fixed.
Now, UnknownDecoder has a content class of (scalar) String.
This is much more sensible and easier to implement, and it
avoids (any?) problems with serialization.
I don't know why I didn't do it like that in the first place,
but from the history, it looks like it might be an editing
error in 2003(!). Surprised it hasn't shown up since then.
Compare: https://github.com/Starlink/starjava/compare/674e50df0a0f...234d2fd22381
|