[Sigh] Looks like this also got overlooked in the transition to R2.8.2/4. NOvA had the same issue, but apparently it didn't make it on the GENIE to-do list.
/nusoft/app/externals/nutools/v1_05_01/source/NuReweight/art/NuReweight.cxx
has:
#ifndef SETDIFFXSEC_1ARG
genie::KinePhaseSpace_t space = genie::kPSNull; // kPSQ2fE; // ????
// dsig/dQ2, dsig/dQ2dW, dsig/dxdy ...
newEvent.SetDiffXSec(gtruth.fDiffXsec,space);
// TODO: we don't know currently know what to use ...
// for now just to get things to compile ... Nate needs to look at this
static int nmsg = 10;
if ( nmsg > 0 ) {
std::cerr << "RetrieveGHEP(simb::MCTruth,simb::GTruth) is not correctly setting KinePhaseSpace_t in SetDiffXSec()\n"
<< "At the time of the conversion to R-2_8_0 (2013-05-01) this is not critical\n"
<< "But it should be fixed" << std::endl;
--nmsg;
if ( nmsg == 0 ) std::cerr << "... last of such messages" << std::endl;
}
#else
newEvent.SetDiffXSec(gtruth.fDiffXsec);
#endif
If I remember the discussion at the time Nate Mayer did this NuReweight code, I think we decided that having the wrong KinePhaseSpace_t here doesn't actually affect anything when using the event record to recalculate new weights. But that's memory, we should revisit it and (1) verify that is true (2) expose a public getter in the future.
On Oct 7, 2014, at 12:56 PM, Philip Rodrigues <[log in to unmask]> wrote:
> Hi,
>
> In the minerva software, we store Genie events as a custom class (Minerva::GenMinInteraction) and then want to convert the events back to genie::EventRecords to be able to get weights for them[1].
>
> In the conversion step, we do (essentiallly):
>
> eventRecord->SetDiffXSec( minervaCustomClass->DiffXsec() );
>
> But somewhere between 2.6.2 and 2.8.4, SetDiffXSec changed to require a KinePhaseSpace_t as second argument, so we'd like to just pass the fDiffXSecPhSp member through our custom class. But there's no public getter for this member variable.
>
> Do you have any recommendations for what we should do?
>
> Thanks,
> Phil
>
> 1. Full code is here:
> http://cdcvs.fnal.gov/cgi-bin/public-cvs/cvsweb-public.cgi/AnalysisFramework/Ana/MCReweight/src/RetrieveGHEP.cpp?rev=1.4&content-type=text/x-cvsweb-markup&cvsroot=mnvsoft&sortby=date
|