Yes, as you know we can help with that. At ESRF they also run a squish test (or maybe more than one) to ensure that their use case(s) continue working. We can also help setting this up.
Matt
-----Original Message-----
From: Gero Flucke [mailto:[log in to unmask]]
Sent: 08 April 2014 13:43
To: [log in to unmask]
Subject: Re: [DAWN-DEV] LoaderFactory DataHolder->IDataHolder
On Tue, 8 Apr 2014, [log in to unmask] wrote:
> Yes it would! If you want to share the code somewhere I will fix it for you.
Hi Matt,
OK thanks, will do so in a private mail.
If here at DESY we decide to regularly build a DESY-flavour of DAWN, we will have to set up things like git repos and a build machinery, etc...
Cheers
Gero
> -----Original Message-----
> From: Gero Flucke [mailto:[log in to unmask]]
> Sent: 08 April 2014 13:04
> To: [log in to unmask]
> Subject: Re: [DAWN-DEV] LoaderFactory DataHolder->IDataHolder
>
> On Mon, 7 Apr 2014, [log in to unmask] wrote:
>
>> Some time early in this devel cycle I would like to change
>> LoaderFactory to return IDataHolder from a getData(...) call rather
>> than the concrete DataHolder. The interface will have most of the
>> methods of the concrete class and I will deal with all of the fall out
>> in your code in master (I do every release but normally I have Matthew
>> Webber to also take part in this process).
>
> Hi Matt,
> thanks for letting me know on this channel.
> Not yet knowing much of the DAWN java internals, let me ask whether this means some adjustments the file loader for DESY .fio files that is defined as
>
> public class FioLoader extends AbstractFileLoader implements IMetaLoader {
>
> Its core method returns a DataHolder:
>
> public DataHolder loadFile() throws ScanFileHolderException {
>
> Cheers
>
> Gero
>
>> This change is much smaller and lower risk in theory than previous
>> refactorings, but I thought it would be friendly to let you know. I
>> need to do this in order to break some hard dependencies because
>> IDataHolder has far less dependencies than its concrete counterpart.
>>
>> Matt
>>
>>
>>
>>
>
> --
> -----------------------------------------------------------------------
> Gero Flucke
> Group 'Experiment Control' (FS-EC)
> * Scientific Software
> DESY
> (Room 228, Bldg. 25b)
> Notkestr. 85
> 22607 Hamburg
> Germany
> Tel: +49 (0)40 8998 1985
>
> --
> This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
> Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
> Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
> Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
>
>
--
-----------------------------------------------------------------------
Gero Flucke
Group 'Experiment Control' (FS-EC)
* Scientific Software
DESY
(Room 228, Bldg. 25b)
Notkestr. 85
22607 Hamburg
Germany
Tel: +49 (0)40 8998 1985
--
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
|