On Mon, 7 Apr 2014, [log in to unmask] wrote:
> Some time early in this devel cycle I would like to change
> LoaderFactory to return IDataHolder from a getData(...) call rather than
> the concrete DataHolder. The interface will have most of the methods of
> the concrete class and I will deal with all of the fall out in your code
> in master (I do every release but normally I have Matthew Webber to also
> take part in this process).
Hi Matt,
thanks for letting me know on this channel.
Not yet knowing much of the DAWN java internals, let me ask whether this
means some adjustments the file loader for DESY .fio files that is defined
as
public class FioLoader extends AbstractFileLoader implements IMetaLoader {
Its core method returns a DataHolder:
public DataHolder loadFile() throws ScanFileHolderException {
Cheers
Gero
> This change is much smaller and lower risk in theory than previous
> refactorings, but I thought it would be friendly to let you know. I need
> to do this in order to break some hard dependencies because IDataHolder
> has far less dependencies than its concrete counterpart.
>
> Matt
>
>
>
>
--
-----------------------------------------------------------------------
Gero Flucke
Group 'Experiment Control' (FS-EC)
* Scientific Software
DESY
(Room 228, Bldg. 25b)
Notkestr. 85
22607 Hamburg
Germany
Tel: +49 (0)40 8998 1985
|