JiscMail Logo
Email discussion lists for the UK Education and Research communities

Help for STARDEV Archives


STARDEV Archives

STARDEV Archives


STARDEV@JISCMAIL.AC.UK


View:

Message:

[

First

|

Previous

|

Next

|

Last

]

By Topic:

[

First

|

Previous

|

Next

|

Last

]

By Author:

[

First

|

Previous

|

Next

|

Last

]

Font:

Proportional Font

LISTSERV Archives

LISTSERV Archives

STARDEV Home

STARDEV Home

STARDEV  October 2013

STARDEV October 2013

Options

Subscribe or Unsubscribe

Subscribe or Unsubscribe

Log In

Log In

Get Password

Get Password

Subject:

[Starlink/starjava] 4e8167: ttools: remove no-longer-required JyStilts workaro...

From:

GitHub <[log in to unmask]>

Reply-To:

Starlink development <[log in to unmask]>

Date:

Thu, 24 Oct 2013 03:47:05 -0700

Content-Type:

multipart/mixed

Parts/Attachments:

Parts/Attachments

text/plain (156 lines)

  Branch: refs/heads/master
  Home:   https://github.com/Starlink/starjava
  Commit: 4e8167d8e3f922c2b878ace6da248e48914860da
      https://github.com/Starlink/starjava/commit/4e8167d8e3f922c2b878ace6da248e48914860da
  Author: Mark Taylor <[log in to unmask]>
  Date:   2013-10-24 (Thu, 24 Oct 2013)

  Changed paths:
    M ttools/src/main/uk/ac/starlink/ttools/build/JyStilts.java

  Log Message:
  -----------
  ttools: remove no-longer-required JyStilts workaround code

JyStilts had code that hacked around some inaccessible methods in
stilts.  These methods will be accessible in any version of stilts
that this version of JyStilts is likely to be working with, so
remove it.


  Commit: 317360e74e8b58f0e1118d13400b1fb18310af80
      https://github.com/Starlink/starjava/commit/317360e74e8b58f0e1118d13400b1fb18310af80
  Author: Mark Taylor <[log in to unmask]>
  Date:   2013-10-24 (Thu, 24 Oct 2013)

  Changed paths:
    M ttools/src/docs/sun256.xml
    M ttools/src/main/uk/ac/starlink/ttools/build/JyStilts.java
    M ttools/src/main/uk/ac/starlink/ttools/task/ChoiceMode.java

  Log Message:
  -----------
  ttools: fix broken non-table-producing JyStilts commands.

Some commands (pixfoot and tcube) do not output tables but are
instances of ConsumerTask.  The JyStilts script was incorrectly
identifying these as commands that present a table as their
primary output.  This caused both a documentation bug, and an
execution bug, since the ProcessingMode that did the work for
them was not getting invoked.  Fix the identification in JyStilts
so that only tasks which output via ChoiceMode are marked thus;
others are executed without special arrangements for making the
result available in python.


  Commit: 40f1aaa2d897b93fd7c695a4bc829515278a720c
      https://github.com/Starlink/starjava/commit/40f1aaa2d897b93fd7c695a4bc829515278a720c
  Author: Mark Taylor <[log in to unmask]>
  Date:   2013-10-24 (Thu, 24 Oct 2013)

  Changed paths:
    M topcat/src/docs/sun253.xml
    M ttools/src/docs/sun256.xml
    M ttools/src/main/uk/ac/starlink/ttools/jel/JELRowReader.java

  Log Message:
  -----------
  ttools: add missing getLongArrayProperty method to JELRowReader

The absence of this method meant that JEL expressions attempting to
subscript long arrays failed.  I'm 95% sure that its omission in
the first place was just an oversight rather than for some subtle
JEL reason.


  Commit: 9dd8af72ef6cf82a48ac8a24cd11c6d8a4f2ed92
      https://github.com/Starlink/starjava/commit/9dd8af72ef6cf82a48ac8a24cd11c6d8a4f2ed92
  Author: Mark Taylor <[log in to unmask]>
  Date:   2013-10-24 (Thu, 24 Oct 2013)

  Changed paths:
    M table/src/main/uk/ac/starlink/table/join/EqualsMatchEngine.java
    M table/src/testcases/uk/ac/starlink/table/join/EqualsMatchEngineTest.java
    M topcat/src/docs/sun253.xml
    M ttools/src/docs/sun256.xml

  Log Message:
  -----------
  table: EqualsMatchEngine now matches scalar numbers on value

The Exact match engine now considers two Number instances equal if they
have the same numeric value; so an Integer can now match a Long or a
Float etc.

Also fixed a bug which could (very rarely) cause a ClassCastException
when attempting to match array values of different types.


  Commit: 87425e1b7f2fb2fe25d45cbdc6c726ddd299488e
      https://github.com/Starlink/starjava/commit/87425e1b7f2fb2fe25d45cbdc6c726ddd299488e
  Author: Mark Taylor <[log in to unmask]>
  Date:   2013-10-24 (Thu, 24 Oct 2013)

  Changed paths:
    M registry/build.xml
    M registry/src/main/uk/ac/starlink/registry/RegistryRequestFactory.java

  Log Message:
  -----------
  registry: fix namespace in SOAP RI1.0 Search request

There was an error in the SOAP request sent for RI1.0 Search operations
by the registry client.  It was generating SOAP messages that started
like this:

   <rs:Search xmlns:rs='http://www.ivoa.net/wsdl/RegistrySearch/v1.0'>
     <rs:Where xmlns:rs="http://www.ivoa.net/xml/ADQL/v1.0"
         xmlns:ad="http://www.ivoa.net/xml/ADQL/v1.0"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
       <ad:Condition xsi:type="ad:likePredType">

The remapping of the rs prefix to the ADQL namespace is clearly wrong.
This was spotted by Menelaus Perdikeas at ESAC.

The problem was related to the fact that the Where element is generated
(by the Where2DOM class in the RAYREG package) in the ADQL namespace,
but it needs to be in the RS namespace.  I had noticed that, and
attempted to patch it up with the line:

   whereEl.setPrefix( "rs" );

Unfortunately, this does something completely different from what
I intended/hoped/assumed.

I've now rewritten it using DOM methods to generate the right starting
elements, namely:

   <rs:Search xmlns:rs="http://www.ivoa.net/wsdl/RegistrySearch/v1.0">
     <rs:Where>
       <ad:Condition xmlns:ad="http://www.ivoa.net/xml/ADQL/v1.0"
               xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
               xsi:type="ad:likePredType">

The broken code was in place for many years.  Although it worked with
the AstroGrid and Euro-VO registries, and an earlier incarnation of
the STSci/NVO/VAO registry service, it did not work after about mid-2010
with the STSci one.


  Commit: 5303b7902c12fefe15802ca558ea5b66a1fff405
      https://github.com/Starlink/starjava/commit/5303b7902c12fefe15802ca558ea5b66a1fff405
  Author: Mark Taylor <[log in to unmask]>
  Date:   2013-10-24 (Thu, 24 Oct 2013)

  Changed paths:
    M topcat/src/docs/sun253.xml
    M ttools/src/docs/sun256.xml

  Log Message:
  -----------
  registry: note regclient fix in user docs


Compare: https://github.com/Starlink/starjava/compare/3eb570e3e252...5303b7902c12

Top of Message | Previous Page | Permalink

JiscMail Tools


RSS Feeds and Sharing


Advanced Options


Archives

December 2023
January 2023
December 2022
July 2022
June 2022
April 2022
March 2022
December 2021
October 2021
July 2021
April 2021
January 2021
October 2020
September 2020
August 2020
May 2020
November 2019
October 2019
July 2019
June 2019
February 2019
January 2019
December 2018
November 2018
August 2018
July 2018
May 2018
April 2018
March 2018
February 2018
December 2017
October 2017
August 2017
July 2017
May 2017
April 2017
February 2017
January 2017
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
May 2016
April 2016
March 2016
February 2016
January 2016
December 2015
October 2015
September 2015
August 2015
April 2015
March 2015
February 2015
January 2015
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
2004
April 2003
2003


JiscMail is a Jisc service.

View our service policies at https://www.jiscmail.ac.uk/policyandsecurity/ and Jisc's privacy policy at https://www.jisc.ac.uk/website/privacy-notice

For help and support help@jisc.ac.uk

Secured by F-Secure Anti-Virus CataList Email List Search Powered by the LISTSERV Email List Manager