Thank you David, Tim, and Graham for all of your help with this issue,

This latest fix is working great!

Cheers,
Matt

On 2012-12-21, at 1:51 AM, David Berry wrote:

> I've just modified smf_fix_metadata_scuba2.c to ignore bad RTS_END values.
> 
> David
> 
> 
> On 21 December 2012 04:38, Tim Jenness <[log in to unmask]> wrote:
>> Yes, the problem is that in all previous simulated and real files the
>> RTS_END value is present in JCMTSTATE. This is used to calculate the step
>> time and really should be present for any valid time series.
>> 
>> Obviously the fix is to fix the step time calculation to ignore bad values.
>> 
>> 
>> On Thu, Dec 20, 2012 at 3:30 PM, Graham Bell <[log in to unmask]> wrote:
>>> 
>>> Hello,
>>> 
>>> It looks like the step time is being recalculated in
>>> smf_fix_metadata_scuba2.c from line 189 onwards.
>>> 
>>> After setting:
>>> 
>>> setenv MSG_FILTER all
>>> 
>>> It prints:
>>> 
>>> Recalculated step time as -inf sec from JCMTSTATE (was 0.0057226 sec)
>>> 
>>> Best regards,
>>> Graham
>>> 
>>> 
>>>> Date: Thu, 20 Dec 2012 12:11:11 -1000
>>>> From: Graham Bell <[log in to unmask]>
>>>> 
>>>> Reply-To: Starlink Software User Support <[log in to unmask]>
>>>> To: [log in to unmask]
>>>> Subject: Re: smurf: AST: Error at line 149 in file kpgPtfts.c
>>>> 
>>>> 
>>>> Hello,
>>>> 
>>>> I had kpgPtfts print out the AST fitschan, and the STEPTIME inside is
>>>> indeed -inf.:
>>>> 
>>>>   Cm144 = "---- JOS parameters ---- "  # FITS keyword comment
>>>>   Nm145 = "STEPTIME"   # FITS keyword name
>>>>   Ty145 = "floating point"     # FITS keyword data type
>>>>   Dt145 = -inf         # FITS keyword value
>>>> 
>>>> So it doesn't look like the error is caused by this library itself.  Is
>>>> the step time being recalculated in a way that includes the null data in the
>>>> JCMTSTATE structure, due to it having been shorter than the data array?  If
>>>> so then the real solution might be to properly resample the JCMTSTATE at the
>>>> same time as the data array, but it might be possible to find a quicker
>>>> short-term solution.
>>>> 
>>>> Best regards,
>>>> Graham
>>>> 
>>>> 
>>>>> Date: Thu, 20 Dec 2012 21:26:46 +0000
>>>>> From: "Sherwood, Matt" <[log in to unmask]>
>>>>> Reply-To: Starlink Software User Support <[log in to unmask]>
>>>>> To: [log in to unmask]
>>>>> Subject: smurf: AST: Error at line 149 in file kpgPtfts.c
>>>>> 
>>>>> Hi All,
>>>>> 
>>>>> I'm having a peculiar problem when trying to copy FITS header data from
>>>>> one NDF file to another. In the first case, using fts2init, it works fine,
>>>>> but in the second case, using fts2phasecorrds it fails.
>>>>> 
>>>>> The line it is failing on calls:  astFindFits(lchan, "%f", card, 1) when
>>>>> the card value is "---- JOS parameters ----", which returns 0 (failure),
>>>>> while the error reported refers to the next card value (which should not
>>>>> have been read yet): 'STEPTIME'. It reports that it cannot get a floating
>>>>> point value for this keyword. I'm baffled as to why it is failing the second
>>>>> time through.
>>>>> 
>>>>> In smurf_fts2_phasecorrds.c, we are are doing a smf_deepcopy_smfData(),
>>>>> but the problem occurs within a following call to smf_write_smfData().
>>>>> 
>>>>> Any insights would be greatly appreciated. We're trying to get the
>>>>> pipeline working for the team who are commissioning the new FTS-2 in
>>>>> conduction with the SCUBA-2 at JCMT Hawaii this week.
>>>>> 
>>>>> Thanks,
>>>>> Matt
>>>> 
>>>> 
>>>> ----
>>>> Starlink User Support list
>>>> For list configuration, including subscribing to and unsubscribing from
>>>> the list, see
>>>> https://www.jiscmail.ac.uk/cgi-bin/webadmin?A0=STARLINK
>>>> 
>>> 
>>> ----
>>> Starlink User Support list
>>> For list configuration, including subscribing to and unsubscribing from
>>> the list, see
>>> https://www.jiscmail.ac.uk/cgi-bin/webadmin?A0=STARLINK
>> 
>> 
>> ---- Starlink User Support list For list configuration, including
>> subscribing to and unsubscribing from the list, see
>> https://www.jiscmail.ac.uk/cgi-bin/webadmin?A0=STARLINK
> 
> ----
> Starlink User Support list
> For list configuration, including subscribing to and unsubscribing from the list, see
> https://www.jiscmail.ac.uk/cgi-bin/webadmin?A0=STARLINK

----
Starlink User Support list
For list configuration, including subscribing to and unsubscribing from the list, see
https://www.jiscmail.ac.uk/cgi-bin/webadmin?A0=STARLINK