Branch: refs/heads/master
Home: https://github.com/Starlink/starlink
Commit: 4c1eb5bebb3bb8ac842315549ae4aec45dd16476
https://github.com/Starlink/starlink/commit/4c1eb5bebb3bb8ac842315549ae4aec45dd16476
Author: Tim Jenness <[log in to unmask]>
Date: 2012-09-12 (Wed, 12 Sep 2012)
Changed paths:
M libraries/gsd/gsd_print.c
Log Message:
-----------
gsd: Fix compiler warning
Commit: 04ac25e299557d6eb247bbd01b2686797d484513
https://github.com/Starlink/starlink/commit/04ac25e299557d6eb247bbd01b2686797d484513
Author: Tim Jenness <[log in to unmask]>
Date: 2012-09-12 (Wed, 12 Sep 2012)
Changed paths:
M libraries/gsd/gsd1.h
M libraries/gsd/gsd1_getval.c
M libraries/gsd/gsdGet0x.c
M libraries/gsd/gsdGet1x.c
M libraries/gsd/gsd_f77.c
M libraries/gsd/gsd_print.c
Log Message:
-----------
gsd: Define size of name buffer in a consistent manner
This fixes the very long standing segv we were getting in the
perl GSD test suite with gsdGet1r. We used to get it on linux
and it would be fixed if we turned down optimisation levels. We
therefore put it down to a compiler bug. Today I started getting
it from clang on OSX and it was hitting a stack corruption error.
Looking at the only variable allocated on the stack in gsdGet1x
I had:
char name[15];
and of course that is too small for a string of length 15 plus
a nul terminator. Changing that to 16 fixed everything but I
took the opportunity to use a constant for it throughout the
library.
Compare: https://github.com/Starlink/starlink/compare/73c61d3e9b06...04ac25e29955
|