On 05/12/2011 13:47, Sam Hartman wrote:
> Some comments.
>
> 1) The identity server seems to be a shared library not a server.
> If it's not actually a server (which it doesn't seem to have a good
> reason to be) please call it something other than a server.
> If it is a server, please explain.
Pete> You're right it's not a server. Renamed in the latest version

> 2) You can't lose the existing libmoonshot interfaces. I mean you can
> change their call signatures or names if you like, but the functionality
> of a client application to select an identity with possible prompting is
> required. That's kind of a major use case of the system. So, your
> architecture needs to describe how the interactions between the
> application and the UI are handled. This is presumably either through
> the identity server or another library.
Pete> Agreed. Modified the text and the diagram to address this (I believe).

> 3) The ABI of any library the Moonshot GSS-API component links to needs
> to be rock solid. Is Vala up to this? In particular, have there ever
> been any changes in the evolution of vala over the past 7 years that
> break the ABIs of generated libraries?  If so, please discuss.
Pete> No longer an issue (per your email 05/12/2011 14:39)

> 4) Why is concurrency managed in the identity server rather than the
> storage component?
Pete> It's now assigned to the identity-storage-server component

> 5)  I thought the web provisioning input was .xml. What is a .msht file?
Pete> .msht is an XML file with its own MIME-TYPE 
('application/moonshot+xml') allowing us to create an association with 
our software.

I believe that the version on the Wiki now (committed at Tue, 6 Dec 2011 
10:20:06) addresses all your comments, but I'm happy to hear more!

Regards

Pete
-- 
Pete Fotheringham
Codethink Ltd
http://codethink.co.uk
+44 7740 351755