>>>>> "Pete" == Pete Fotheringham <[log in to unmask]> writes:
Pete> On 29/11/2011 08:42, Luke Howard wrote:
>>> _L flags are included in the other _LD_FLAGS macros
>>> (EAP_LDFLAGS, SHIBSP_LDFLAGS, SHIBRESOLVER_LDFLAGS,
>>> OPENSAML_LDFLAGS, OPENSSL_LDFLAG, RADSEC_LDFLAGS,
>>> LIBMOONSHOT_LDFLAGS and JANSSON_LDFLAGS_.
>>
>> My bad, I assumed they went in LD_FLAGS. Feel free to fix the lot
>> :-)
>>
>> -- Luke
Pete> I would prefer not to - it's consistent and it works (and has
Pete> worked for a while). With my changes it now works and picks up
Pete> the correct Krb. Changing stuff that works because it is
Pete> typically done differently is not necessarily time well spent
Pete> in my view.
Pete> Sam's call I guess: if he doesn't want to accept the patches
Pete> as they are, then I can spend the time to change all the
Pete> flags, but this will then delay delivery of the stuff I would
Pete> be doing instead.
Pete> Regards
Pete> Pete
Pete> -- Pete Fotheringham Codethink Ltd http://codethink.co.uk +44
Pete> 7740 351755
Well, I would have accepted the patch if it was at least consistent.
You ended up with the krb5 library directory substituted twice.
|