JiscMail Logo
Email discussion lists for the UK Education and Research communities

Help for MOONSHOT-COMMUNITY Archives


MOONSHOT-COMMUNITY Archives

MOONSHOT-COMMUNITY Archives


MOONSHOT-COMMUNITY@JISCMAIL.AC.UK


View:

Message:

[

First

|

Previous

|

Next

|

Last

]

By Topic:

[

First

|

Previous

|

Next

|

Last

]

By Author:

[

First

|

Previous

|

Next

|

Last

]

Font:

Proportional Font

LISTSERV Archives

LISTSERV Archives

MOONSHOT-COMMUNITY Home

MOONSHOT-COMMUNITY Home

MOONSHOT-COMMUNITY  June 2011

MOONSHOT-COMMUNITY June 2011

Options

Subscribe or Unsubscribe

Subscribe or Unsubscribe

Log In

Log In

Get Password

Get Password

Subject:

Re: Moonshot UI & Services

From:

Sam Hartman <[log in to unmask]>

Reply-To:

Moonshot community list <[log in to unmask]>, Sam Hartman <[log in to unmask]>

Date:

Tue, 21 Jun 2011 08:36:57 -0400

Content-Type:

text/plain

Parts/Attachments:

Parts/Attachments

text/plain (94 lines)

>>>>> "Javier" == Javier Jardón <[log in to unmask]> writes:

    Javier> On Thu, 2011-06-02 at 13:32 -0400, Sam Hartman wrote:
    >> Hi.  So, I think I'd like to take a step back here.
    >> 
    >> I'd like to ask you to document MoonshotServer.get_identity.  On
    >> inspection, I don't think it particularly does what I'd expect it
    >> to do, and it's what I'd expect to involve services.

    Javier> That's done now, take a look to this commit [1]

I've duplicated the documentation below for the convenience of the list:

    /**
     * This is the function used by the GSS mechanism to get the NAI,
     * password and certificate of the ID card for the specificated service.
     *
     * The function will block until the user choose the ID card.
     *
     * @param nai NAI of the ID Card (optional)
     * @param password Password of the ID Card (optional)
     * @param service Service application request an ID Card for

First, service may be optional as well. See the  first attachment to my
mail to Codethink last Monday.


     * @param nai_out NAI stored in the ID Card
     * @param password_out Password stored in the ID Card
     * @param certificate Certificate stored in th ID Card
     *
     * @return true if the user choose a correct ID card for that service,
     *         false otherwise.
     */

This doesn't seem right.
My understanding is that we're storing a set of services associated with
an ID card to  automate selection in cases where the user has already
chosen something.
This code seems to fail if the service is not attached to the ID card.

I'd expect this code to implement an algorithm similar to the one
described in "selecting a service" on
http://www.project-moonshot.org/devwiki/design/identity-provisioning/

The current version can be simpler because no rules will trigger since
rules have not been implemented, but I'd still expect a reasonably
complicated algorithm that dealt with automating things when the user
had previously selected an identity for a given service, and that
updated the service list associated with an ID card appropriately.

Also, previously, Rob said that the MSRPC and DBUS code was inherently
different and so different implementations would be needed, but all the
application logic would be in common code.  However, there seems to be
significant logic that is cut&paste between moonshot-dbus-server.vala
and moonshot-msrpc-server.vala. The thing that mostly stands out is that
the loop that figures out whether a service is present in the ID card is
duplicated between these two functions.

I think code refactoring is required and more of the implementation
needs to move into the request object. Both get_identity for dbus and
msrpc have approximately the same signatures (we'd expect this).
So, I'd expect the flow to be:

* construct a request object passing  in the inputs
* manage to arrange for a callback and yield in rpc-specific manner
* call a single method to retrieve the outputs from the request



    >> I suspect once you've written a design for the get_identity
    >> interface we'll be better in a position to understand the
    >> disconnect and where we're missing uses of services.

    Javier> I have a question here: should be the identity cards say
    Javier> what services they provide, or is this done automatically
    Javier> when the application makes the first identity request?

I don't understand the question.

    >> I'm also concerned about the implementation of this interface.
    >> There appears to be a single callback on the main window. What
    >> happens when two different processes call
    >> MoonshotServer.set_identity at the same time?

    Javier> This should be fixed later today

It seems fixed for Linux.  However for Windows, the RPC thread is left
blocked while the request is outstanding.
Does the runtime create new threads for each request? If not, will each
request be processed serially?

--Sam

Top of Message | Previous Page | Permalink

JiscMail Tools


RSS Feeds and Sharing


Advanced Options


Archives

April 2024
March 2022
December 2021
October 2021
September 2021
August 2021
June 2021
April 2021
February 2021
January 2021
December 2020
November 2020
October 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
January 2020
November 2019
October 2019
September 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
December 2018
June 2018
April 2018
November 2017
October 2017
September 2017
August 2017
July 2017
May 2017
April 2017
March 2017
February 2017
November 2016
October 2016
August 2016
July 2016
June 2016
May 2016
March 2016
February 2016
January 2016
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010


JiscMail is a Jisc service.

View our service policies at https://www.jiscmail.ac.uk/policyandsecurity/ and Jisc's privacy policy at https://www.jisc.ac.uk/website/privacy-notice

For help and support help@jisc.ac.uk

Secured by F-Secure Anti-Virus CataList Email List Search Powered by the LISTSERV Email List Manager