> Date: Mon Dec 20 11:44:45 2010 -1000
>
> dipso: Fix use of P format specifier
>
> The F77 standard seems to imply that the P specifier must be
> followed by a comma and modern gfortran compilers seem to insist
> on this. This patch adds the commas.
I looked at this four weeks ago after a compiler version change
following an OS upgrade. There seemed to be conflicting views whether
or not the comma was required, including in gfortran circles. Adding
the comma is of course safe.
Section 13.2 of the F77 Standard it states "The comma used to separate
list items in the list flist may be omitted as follows:
1. Between a P edit descriptor and an immediately following F, E, D,
or G edit descriptor ( 13.5.9)"
flist is the format specification.
While some of the DIPSO instances the E didn't follow immediately (there
was a parenthesis or repeat counter), for some it did, and still
gfortran complained. In a further twist Ian Howarth saw more errors
than I with the compiler he used, possibly the same number at Tim saw.
There was a bug fixed in gfortran last year relating to this
(http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41154), but it seems not to
have been included in the version I'd been running as it still
complained about a valid "1PE15.3". To add to the confusion there are
parallel series of versions, e.g. Version 4.5.0 was released before
4.4.4 which in turn appeared before 4.3.5. Which version are you using
Tim? Version 4.3.2 doesn't complain with the old dipso.f unlike 4.5.0.
With other fish to fry at the time I stashed my changes and reverted
gfortran so I could complete a make world, then forgot about it.
Malcolm
|