Commit summary from repository starlink
------------------------------------
(Ed Chapin) smf: factor writing of itermap extension out to smf_write_itermap
100.0% applications/smurf/libsmf/
(Malcolm J. Currie) KAPPA: Adding TEMPSTYLE to NORMALIZE, PSF, and SCATTER.
100.0% applications/kappa/
(Malcolm J. Currie) KAPLIBS: Retrieve unintentional commits of non-split hunks.
68.4% applications/kappa/
31.5% libraries/kaplibs/kpg/
Commits from repository starlink
-----------------------------
commit 128ed3214bc7273640c998a42138b8f98d49b2c6
Author: Ed Chapin <[log in to unmask]>
Date: Fri Aug 13 11:00:03 2010 -0700
smf: factor writing of itermap extension out to smf_write_itermap
applications/smurf/libsmf/Makefile.am | 1 +
applications/smurf/libsmf/smf.h.source | 8 +
applications/smurf/libsmf/smf_iteratemap.c | 96 +---------
applications/smurf/libsmf/smf_write_itermap.c | 216 +++++++++++++++++++++++
4 files changed, 235 insertions(+), 86 deletions(-)
commit 5200870390c1e77d8db1b5ec228ef3d6624ed40c
Author: Malcolm J. Currie <[log in to unmask]>
Date: Tue Aug 17 15:47:30 2010 +0000
KAPPA: Adding TEMPSTYLE to NORMALIZE, PSF, and SCATTER.
The introduction of TEMPSTYLE parameter to HISTOGRAM has the
ramification of adding it to NORMALIZE, PSF, and SCATTER because they
all use KPG1_GRPHW via KPG1_GRAPH. I shall omit documenting this for
now in case we can find a programmatic route in the Parameter System
that avoids the use of an additional parameter for each style parameter.
At present it's only LINPLOT and recently HISTOGRAM that has
TEMPSTYLE, so it's not too late to put the genie back in the bottle
(although we may have to retain TEMPSTYLE in LINPLOT for backwards
compatibility).
applications/kappa/kappa.ifd.in | 27 +++++++++++++++++++++++++++
1 files changed, 27 insertions(+), 0 deletions(-)
commit e4983224d8cf5bca2936e8facdb9b6b32b796eed
Author: Malcolm J. Currie <[log in to unmask]>
Date: Tue Aug 17 13:26:53 2010 +0000
KAPLIBS: Retrieve unintentional commits of non-split hunks.
This is the version of KPG1_PLOT I thought I had committed last night.
To restore where we should have been, withdraw the temporary
workaround to the KAPPA interface file.
A couple of hunks were not split on the second or third iteration of
"git add -p" to remove trailing blanks, and these included the part of
the TEMPSTYLE changes. Apologies for the carelessness. The plan was
to hold back on the addition of TEMPSTYLE in KPG1_PLOT, because after
delving deeper I discovered it was not part of the HISTOGRAM fix, and
if applied it would break several heavily used KAPPA applications.
Also we had not discussed the wider use of TEMPSTYLE, whether or not
it was the right approach. If so, what should we do in the likes of
CLINPLOT where there are two main style files, or other tasks where
there's a KEYSTYLE. Another route might be to include a special
character or keyword in a style group to indicate that style attributes
following it only apply to the current invocation. That way to you
wouldn't need mirror TEMP<whatever>STYLE parameters for every
<whatever>STYLE parameter.
When I started the HISTOGRAM TEMPSTYLE addition, it was not
immediately clear which subroutines needed changing, as STYLE doesn't
appear in the code of histogram.f, unlike in linplot.f (appearing in
KPG1_ASSET and KPG1_PLTLN calls). I shall continue to comment in the
application code where certain fixed-name parameters are defined to
help with maintenance.
applications/kappa/kappa.ifd.in | 54 -----------------------------------
libraries/kaplibs/kpg/kpg1_plot.f | 11 +------
2 files changed, 1 insertions(+), 64 deletions(-)
|
