On Wed, 28 Apr 2010, Peter W. Draper wrote:
> On Wed, 28 Apr 2010, Malcolm J. Currie wrote:
>
>>> No Malcolm is nearly right about these files. For instance docs/sc/002 has
>>> whitespace removed from the component.xml.in, but the related
>>> component.xml hasn't been regenerated, so in fact the difference is a
>>> removal of trailing whitespace not an insertion.
>>
>> That's what I thought had happened when I first saw them, noting Tim's
>> change. I was looking forward to insert "ironic" in my e-mail. It's the
>> "gif diff" to xxdiff made it look the other way around. Better check that
>> to avoid further opposite-sense interpretations.
>>
>>> Need to reconfigure the whole tree to pick up any missing changes.
>>
>> That's what I'd done, started from a fresh clone.
>
> Ok, so give them a quick review and commit, but maybe we'd better wait and
> see what Tim has to say first.
>
Ok. These should not be committed as is. The problem seems to be that when
a package has no dependencies the <dependencies> section has trailing
space in it. The fix is to remove the padding from the component.xml.in
files in that case.
--
Tim Jenness
JAC software
http://www.jach.hawaii.edu/~timj
|