On Aug 11, 2009, at 5:03 AM, Michael Reid wrote:
> Hi, Brad.
>
> I'm using the 64 bit version of Nanahope on my laptop, but it
> doesn't seem to have the eNaN issue (see my previous message).
> Still, since Tim's patch has changed other things, I'd appreciate
> having it. I will update my other installations to 64 bit nanahope,
> I suppose.
>
Brad will get you those fixes.
> I would like to recommend another change. Many starlink routines
> seem to barf on .sdf file names which have a period other than the
> one immediately before 'sdf'. For example, if a file is called
> ft_1.6_0.sdf, starlink routines go looking for ft_1.sdf. I solve
> this problem on my own by always substituting a 'p' for a '.' in the
> middle of a file name. However, some routines take header keywords
> and create filenames from them that they cannot read in later.
>
Starlink has always treated the "." as a separator in the hierarchy
inside the file. It has only been 2 or 3 years since people were
allowed to include the ".sdf" in the filename. Space and "." in
directories and file names are still tricky. I occasionally take a
small look at the problem but no fixes yet. The "." in filename would
really require me to continue the ".sdf" trick where I have to open
the file and look inside just in case it happens to be a "SDF"
structure. Supporting "." in the filename would require a little extra
overhead.
> For example, if I give remdbm an NDF with CHOP_THR set to a non-
> integer value, it then creates a file with the CHOP_THR keyword in
> its name. This happens just before it calls scumakewt. The
> scumakewt call then fails because it interprets the filename
> incorrectly, as in the example I just described. I fixed this
> myself in remdbm.pl by adding the line
>
> $chop_thr =~ s/\./p/;
>
> right before:
>
> $outwt = 'wt_' . $chop_pa . '_' . $chop_thr;
> $outft = 'ft_' . $chop_pa . '_' . $chop_thr;
>
> That fixes the problem in this particular instance, but not generally.
>
Thanks. Applied as
http://starlink.jach.hawaii.edu/git/?p=starlink.git;a=commit;h=6c3e8812358617c90c03659115a407edfaf5e771
with a minor tweak.
--
Tim Jenness
|