On Jul 10, 2009, at 5:19 AM, Peter W. Draper wrote:
> On Thu, 9 Jul 2009, Tim Jenness wrote:
>
>> Example 2: KPG1_ISCLx seems to have a bug fix in CCDPACK that is
>> subtly different in KAPLIBS. Also the UPPER and LOWER arguments in
>> CCDPACK version are forced to DOUBLE whereas KAPLIBS uses generic
>> type. This one may prove the most interesting to merge. It will
>> affect KAPPA usage.
>
> Except for the DOUBLE PRECISION arguments these are identical
> (comment formatting aside, oddly I seem to have kept Malcolm's usual
> style and the KAPPA version hasn't). Must have shared that change.
>
Well, by subtly different I meant that the patch was clearly manually
written rather than a file copy since there are differences in
approach. eg
- UL = DBLE( VAL__MAXI )
- LL = DBLE( VAL__MINI )
- DL = LOWER
- DU = UPPER
+ UL = NUM_ITOD( VAL__MAXI )
+ LL = NUM_ITOD( VAL__MINI )
+ DL = NUM_<T>TOD( LOWER )
+ DU = NUM_<T>TOD( UPPER )
but I see that part of that patch was actually done by me! (the use of
NUM_ITOD). Wow. Interesting that the comment on the fix for non-
inverting loops does not appear in the KAPLIBS version in any way but
the patch must have been applied to both.
>> 4: KPG1_TRBO
>>
>> adds some code in ccdpack. Should it be in KAPLIBS? I assume so
>> since it is initialisation code.
>>
>> DO IAXIS = 1, NDIMI
>> BOUNDI( 1, IAXIS ) = LBND( IAXIS )
>> -
>> -* And also for the other axes.
>> - IF ( NDIMI .GT. 1 ) THEN
>> - DO I = 2, MAXPTS
>> - BOUNDI( I, IAXIS ) = LBND( IAXIS )
>> - END DO
>> - END IF
>> END DO
>>
>> All the others seem to be identical.
>
> One for Malcolm, I doubt I did that.
This is the last one that needs a decision but I can apply it to
kaplibs at any time since it seems to be open to debate. It was a
patch by Mark.
--
Tim Jenness
Joint Astronomy Centre
|