On Mon, 13 Jul 2009, Peter W. Draper wrote:
> On Fri, 10 Jul 2009, Tim Jenness wrote:
>
>> > > Also the UPPER and LOWER arguments in CCDPACK version are forced to
>> > > DOUBLE whereas KAPLIBS uses generic type. This one may prove the most
>> > > interesting to merge. It will affect KAPPA usage.
>> >
>> > Given that the only thing the KAPLIBS versions does with the UPPER and
>> > LOWER arguments is to convert them to double, it would seem reasonable
>> > to make the arguments double in the first place.
>>
>>
>> Yes. I thought that. But pragmatism may lead me to go the other way for
>> the moment since KPG1_ISCLx is used in many places in KAPPA (and KAPRH)
>> and uses the return values from KPG1_MXMNx (which is typed) in places, but
>> ccdpack only uses it in one routine (ccd1_prndf) so it would be much less
>> work to convert the double to type and back to double again (hoping that
>> rounding errors don't bite). I assume I can just add NUM_DTO<T>(LOWVAL) in
>> all the calls rather than creating new variables...
>
> They maybe nothing to decide here. I see that CCD1_PRNDF isn't called
> anywhere. It's a routine that supported IDI graphics, which is no longer used
> in CCDPACK (since Mark's Tcl/Tk UI work replace all that). So just
> remove?
>
Well, if nothing is using a routine it would be nice to delete it! I
removed a few routines on Friday that were unused. That "ccdpack/obsolete"
directory also annoys when using ack/grep.
So, the kaplibs transition is done apart from the mystery of the
initialisation code from Peter.
--
Tim Jenness
JAC software
http://www.jach.hawaii.edu/~timj
|