On Jul 10, 2009, at 4:42 AM, David Berry wrote:
>
>> Also the UPPER and LOWER arguments in CCDPACK version
>> are forced to DOUBLE whereas KAPLIBS uses generic type. This one
>> may prove
>> the most interesting to merge. It will affect KAPPA usage.
>
> Given that the only thing the KAPLIBS versions does with the UPPER and
> LOWER arguments is to convert them to double, it would seem reasonable
> to make the arguments double in the first place.
Yes. I thought that. But pragmatism may lead me to go the other way
for the moment since KPG1_ISCLx is used in many places in KAPPA (and
KAPRH) and uses the return values from KPG1_MXMNx (which is typed) in
places, but ccdpack only uses it in one routine (ccd1_prndf) so it
would be much less work to convert the double to type and back to
double again (hoping that rounding errors don't bite). I assume I can
just add NUM_DTO<T>(LOWVAL) in all the calls rather than creating new
variables...
--
Tim Jenness
Joint Astronomy Centre
|