Peter,
On 2006 Jun 2 , at 12.34, Peter W. Draper wrote:
>> Shall I commit this?
>
> May as well, but I think I've messed this up. You shouldn't use
> AM_CONDITIONAL in branched code, plus as you say the Makefile.am
> doesn't
> use it anyway. It used to control the lifting of binaries from
> ITCL, but
> that's no longer used, so they should be removed. I'll have a
> further look
> at this after you've committed the patch.
It hardly seems worth committing it (now I come to look at it), since
it's only one line, once you ignore the stuff about checking $have_itcl
> BTW, I was suggesting that we test if "make configure-deps" has
> been run
> before running the top-level configure, rather than tuning the
> tests that
> depend on this. Wouldn't a AC_CONFIG_SRCDIR() for some product of
> "make
> configure-deps" stop that from running?
There's no such product, since the configure-deps target exists only
as a Makefile target, and the only result of it is to build other
components. However, the result of those is to create files in the
manifests directory.
How about this instead? I amend STAR_DECLARE_DEPENDENCIES so that it
specialcases the [configure] dependencies case, and checks that the
appropriate manifest files exist at configuration time -- that's
exactly the time when this should be declared, and the information
about the dependency is already present in the configure.ac. I think
it'll only be a couple of lines in starconf.m4.in, so if that sounds
reasonable, I'll add them just now.
Nomran
--
------------------------------------------------------------------------
----
Norman Gray / http://nxg.me.uk
eurovotech.org / University of Leicester, UK
|