On Wed, 26 Apr 2006, David Berry wrote:
> The change you made to emsPutc.c on Monday seems to be causing most
> applications I run to fail. E.g. try "hdstrace $KAPPA_DIR/m31". Modifying
>
> /* Update the pointer value. */
> *iposn = *iposn + allow;
>
> to
>
> /* Update the pointer value. */
> *iposn = *iposn + allow - 1;
>
>
> seems to cure it. I havn't committed this change though since I thought
> you should have a look at it first, having made the original changes.
Whoops, sorry about that. You're right that additional change is needed to
make sure that the trailing NULL is overwritten on the next visit. Spent a
while fiddling with the edge case when the message length is 200/201
characters, which now causes core dumps (in GAIA, but presumably it would
elsewhere too, the runtime library is much more sensitive to slight
overruns than previously). So keep an eye out for additional issues with
long messages.
Cheers,
Peter.
|