Tim (et al.),
On 2005 Sep 28 , at 15.24, Tim Jenness wrote:
> I had this problem yesterday but I didn't have a chance to patch
> it. STAR_FCFLAGS needs to be burnt into the alink script (only
> @CFLAGS@ is at present) or alternatively the alink target in
> starconf needs to be giving the flags on the command line to alink.
Thinking about this, I thought STAR_CPPFLAGS would be better, since
it is the C compiler that's being invoked here. There wouldn't be a
difference in fact, since at present the two variables are given
exactly the same value in buildsupport/starconf/starconf.m4.in, but
they could be different, and STAR_FCFLAGS could have Fortran-specific
flags, in principle.
This is preferable to using -I@includedir@, although it would again
amount to the same thing in the most common case. The difference is
twofold: (a) that @includedir@ is the location where the current
component's include files are to be installed, and it is therefore
the same as STAR_*FLAGS when the whole system is being bootstrapped,
so that you can know that fpp.h will have been installed in
@includedir@ already, but different when this component is being
built in isolation, with reference to a pre-existing Starlink tree
(that is, STARCONF_DEFAULT_* are different from each other, or the --
prefix option was present). (b) the STAR_*FLAGS options are blank
when the --without-starlink option was present. I don't recall why
you'd want to, but if you do, you are saying that you don't want any
reference to any Starlink directories by default.
Separately, dtask_wrap.c should really have `#include <f77.h>',
rather than `#include "f77.h">. Again, there's no real difference,
because there won't be a f77.h in the current directory; but in that
case, the distinction between <f77.h> and "f77.h" is not being
exploited, and we shouldn't suggest that it is by using the "...".
See you,
Norman
--
----------------------------------------------------------------------
Norman Gray / http://www.astro.gla.ac.uk/users/norman/
Physics & Astronomy, Glasgow University, UK
|