On Wed, 18 Aug 2004, Norman Gray wrote:
> Tim,
>
> On 2004 Aug 18 , at 08.37, Tim Jenness wrote:
>
> > Aside: It might be best to put the little hack that is currently in CNF
> > configure.ac to get the size of a void* into STAR_FC_SIZEOF_POINTER so
> > that we save the multi-line copy and paste.
>
> Mmm, it was a hack, wasn't it (using undocumented internal variables,
> Tim, you should be ashamed!).
I was, but it's much cleaner than the alternative that you implemented.
Mine took one extra line of code in configure.ac. Yours needed 5 lines of
code in Makefile.am *and* leads to the confusion of having a fortran
include file sitting there with a .c extension... :-)
I'm completely shocked that there is no way to use a define in config.h to
set a variable in the Makefile.
>
> I've modified it so that it uses the SIZEOF_VOIDP value in config.h.
> The result is longer than you had, but possibly cleaner. Even though
> it's longer, I'm reluctant to make yet another custom macro. Makefiles
> fairly inevitably have a certain amount of hoop-jumping in them, and I
> feel this is below the gymnastic level, above which things should be
> quarantined in custom macros. Also, it fits in with a pattern of
> make-time generation of files, which is occasionally necessary.
Obviously now that all the work is in the Makefile.am a STAR_ macro is
useless. I've got to use this hack in ARD and SPECX so I wanted it to be
clean (a single line in configure.ac) rather than a cut-and-paste job.
--
Tim Jenness
JAC software
http://www.jach.hawaii.edu/~timj
|