> (could we have <shift> and <control> for multiple selections in tables?)
Yes. This is already under serious consideration. However it's going
to mean a big overhaul of ScrolledMatrix and hence Analysis in general, so
it may be a while before it is done.
> from the popup - the first one went peacefully, but
> after the second one the table did not update. Tying to delete it again
> produced the following (obviously):
> raise ApiError("Attempt to delete already deleted object")
> ApiError: Attempt to delete already deleted object
>
> Also I notice that if I have the Peak Selection popup open as I select and
> delete peaks from the spectrum windows, the peaks appear in the popup
> after the delete is actioned.
This happens because the list of objects here, unlike most popups is not
derived from a parent's list but from an internal cache. So I will have to
check explicitly for deleted peaks in the cache. I have a fix for this
below.
Also, investigating this popup I think it may be better to move to a
different scheme for what is displayed. Currently the Peak Selection popup
produces a snapshot list of what was selected at the time when the menu
option was selected. However it may be more desirable to have the popup
update continuously to display exactly what is selected in the spectrum
windows at any given time. The second fix creates this behaviour.
Please let me know if you prefer the old 'snapshot' rather than the
'mirror' peak selection.
In SelectPeakPopup.py the fixes are:
To update() before the first "if self.peaks:" add:
for peak in list(self.peaks):
if peak.isDeleted:
self.peaks.remove(peak)
To updateAfter() before "elif object.className == 'Peak':" add:
self.waiting = 1
self.after_idle(self.update)
return
Tim
-------------------------------------------------------------------------------
Dr Tim Stevens Email: [log in to unmask]
Department of Biochemistry [log in to unmask]
University of Cambridge Phone: +44 1223 766022 (office)
80 Tennis Court Road +44 7816 338275 (mobile)
Old Addenbrooke's Site +44 1223 364613 (home)
Cambridge CB2 1GA WWWeb: http://www.bio.cam.ac.uk/~tjs23
United Kingdom http://www.pantonia.co.uk
-------------------------------------------------------------------------------
------ +NH3CH(CH(CH3)OH)C(O)NHCH(CH(CH3)CH2CH3)C(O)NHCH(CH2CH2SCH3)CO2- -------
-------------------------------------------------------------------------------
|