On Wed, 18 Aug 2004, Norman Gray wrote:
> Anyone!
>
> Echomop and Figaro appear to have an entirely unhealthy relationship,
> which can only end in tears. The original makefile links Echomop using
> "-L/star/sources/figaro -lgen" (oh yes, uninstalled private libraries),
> and true enough, if you omit that library, Echomop fails to find the
> symbols
Forgot to mention that JCMT-DR uses uninstalled private includes too
(DYNAMIC_MEMORY and DTACODES) :-) As does CONVERT (DYNAMIC_MEMORY)
>
> _gen_forterr_
This is ems_fioer.c [assuming you need a token rather than a string
- I always forget how to get the string out of the token]
Used once and then sent to ECH_REPORT, which eventually uses MSG_OUT
and could use the token....
> _gen_qfmed_
Find the median of a real array. Used once.
KAPLIBS: kpg1_medr ?
> _gen_medflt_
Median filter a 2D real array. Have no idea. Must be somewhere.
Used 4 times (two routines).
> _gen_centroid_
KAPLIBS: kpg1_loctr
Used 2 times. 2 routines.
> _gen_sortf_
PDA_QSAR
use once.
> _gen_epolyd_
PDA_DPOLFT
Used 5 times in one place, as a function.
> _gen_rangef_
>
Find max and min of an array
KAPLIBS: kpg1_statr
Used once.
> I presume from the name, and from the names of these routines, that
> Figaro's `gen' library is a collection of general utility routines,
> supposedly private to Figaro. Perhaps these ought to be in PDA (I
They don't look like they are anything special. Many of the comments in
the code say things like:
C Evaluates a polynomial - this is an interim version.
C Ideally the VAX POLYD instruction should be used.
C Sorts a real array. Note: a more efficient Macro version
C will eventually replace this routine.
> recall that there are licence problems with Figaro; but there are
> licence problems with the `PD' routines in PDA, so we'd not be
> multiplying our troubles there).
PDA is funny since clearly the intention was to use public domain
routines. Many of the PDA routines are used everywhere so I don't think
it's a problem (but keeping this problem limited to the PDA library is
good).
> Or perhaps we should modify Figaro to install a libfigaro_for_echomop.a
> (my preference right now).
There are only a handful of places to fix up :-)
--
Tim Jenness
JAC software
http://www.jach.hawaii.edu/~timj
|