Peter and Mark,
On 2004 Jun 8 , at 16.58, Norman Gray wrote:
> Good point. I'll translate the URISyntaxException into
> MalformedURLException (which is what the problem really is) and throw
> that.
Done. As part of this I added testcases for URLUtils.
I included testcases for URLUtils.makeURL (Mark, that's yours, yes?),
and included a couple of URLs which I thought it would/should object
to. I was a bit surprised to find that it didn't object, as a result
of its heuristic for working out whether it's making a `file:' URL or
not. Mark, could you look at these and see if you think they should
succeed?
To check that `file:' URLs are being properly escaped by the
URLUtils.urlToUri, I added one for a Windows filesystem, but don't
really know what the expected value should be. Peter, would you and
cygwin be able to take a look at this? Both places are marked with
`XXX'.
The relevant regression tests work, but the whole-tree one doesn't, for
me. I _think_ that's just some local path problems, but checking that
will have to wait until I get back from RAL.
See you all tomorrow,
Norman
--
----------------------------------------------------------------------
Norman Gray / Physics and Astronomy, University of Glasgow, UK
http://www.astro.gla.ac.uk/users/norman/
|